Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add settings for cue to .editorconfig #4426

Merged
merged 1 commit into from
Oct 7, 2020
Merged

Conversation

MOZGIII
Copy link
Contributor

@MOZGIII MOZGIII commented Oct 7, 2020

No description provided.

Signed-off-by: MOZGIII <mike-n@narod.ru>
@binarylogic binarylogic merged commit 689a77c into master Oct 7, 2020
@binarylogic binarylogic deleted the editorconfig-cue branch October 7, 2020 13:16
@bruceg
Copy link
Member

bruceg commented Oct 7, 2020

Is this really what we want? As far as I can determine, all of the existing cue files use 2 space indents and spaces instead of tabs. If I'm reading right, this change sets them up for 4 space indents and tabs only. Without going back and reformatting all the cue files, this will cause a real mess of confusion between tabs, spaces, and indent levels whenever somebody commits changes using this editor config.

While I'm not a big fan of of using tabs for indenting, it's not a strong preference. I just want the formatting to stay consistent to avoid the mess that can follow from a change like this.

@MOZGIII
Copy link
Contributor Author

MOZGIII commented Oct 7, 2020

cue fmt converts to this format, thus it's the obvious pick

@bruceg
Copy link
Member

bruceg commented Oct 7, 2020

I agree, if the standard formatting tool uses this format then it is the obvious pick. I was going off of the PRs I had already worked on.

… I see #4424 has been opened to make sure this happens in the future. My apologies for the noise.

@MOZGIII
Copy link
Contributor Author

MOZGIII commented Oct 7, 2020

No worries, totally reasonable!

mengesb pushed a commit to jacobbraaten/vector that referenced this pull request Dec 9, 2020
Signed-off-by: MOZGIII <mike-n@narod.ru>
Signed-off-by: Brian Menges <brian.menges@anaplan.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants