Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): remove uom as direct dependency #5188

Merged
merged 3 commits into from Nov 28, 2020
Merged

chore(deps): remove uom as direct dependency #5188

merged 3 commits into from Nov 28, 2020

Conversation

fanatid
Copy link
Contributor

@fanatid fanatid commented Nov 23, 2020

We still have uom but as heim dependency.

@fanatid
chore(deps): remove uom as direct dependency
a313f98 
Signed-off-by: Kirill Fomichev <fanatid@ya.ru>
@fanatid fanatid added the domain: deps Anything related to Vector's dependencies label Nov 23, 2020
@fanatid fanatid requested a review from bruceg November 23, 2020 15:37
@fanatid fanatid self-assigned this Nov 23, 2020
@fanatid
Copy link
Contributor Author

fanatid commented Nov 24, 2020

@bruceg do you have any ideas why linking fails on CI? I tested locally and everything compiled successfully.

@bruceg
Copy link
Member

bruceg commented Nov 24, 2020

@bruceg do you have any ideas why linking fails on CI? I tested locally and everything compiled successfully.

I don't know. Note the error though: collect2: fatal error: ld terminated with signal 9 [Killed] The linker died from being sent the KILL signal. This is not a normal link error or bug, it was forcibly killed.

@jamtur01 jamtur01 merged commit 646a5ac into master Nov 28, 2020
@jamtur01 jamtur01 deleted the drop-uom-direct-dep branch November 28, 2020 16:47
mengesb pushed a commit to jacobbraaten/vector that referenced this pull request Dec 9, 2020
@fanatid @jamtur01
chore(deps): remove uom as direct dependency (vectordotdev#5188)
7ef8736 
Co-authored-by: James Turnbull <james@lovedthanlost.net>
Signed-off-by: Brian Menges <brian.menges@anaplan.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bruceg bruceg bruceg approved these changes

Assignees

@fanatid fanatid

Labels
domain: deps Anything related to Vector's dependencies
Projects
None yet
Milestone
2020-11-23: Pseudo-chitin armor
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fanatid @bruceg @jamtur01