New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhancement(kubernetes platform): add the ability to configure Vector API at the Helm charts #6248
Conversation
Signed-off-by: Oleg Tsymbal <dzirg44@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for preparing a PR for us!
This implementation is too complicated, and I suggest we go with a more direct one - as I mention in the comment I left above.
Signed-off-by: Oleg Tsymbal <dzirg44@gmail.com>
Signed-off-by: Oleg Tsymbal <dzirg44@gmail.com>
I made it simpler, but maybe we have to check if we have api vars or not? |
Yeah, |
Signed-off-by: Oleg Tsymbal <dzirg44@gmail.com>
Signed-off-by: Oleg Tsymbal <dzirg44@gmail.com>
Signed-off-by: Oleg Tsymbal <dzirg44@gmail.com>
fixed, also my linter found some wrong whitespaces here , i can delete or keep it. |
Signed-off-by: Oleg Tsymbal <dzirg44@gmail.com>
fixed, thank you for your patience ) |
should I squash commits or you will? |
I'll take care of the squash (in fact, Github will do it for us automatically). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, all that's left is making the checks pass.
You need to:
- sign your commits with DCO (see https://github.com/timberio/vector/blob/master/CONTRIBUTING.md#signing-off)
- run
make update-kubernetes-yaml
andmake update-helm-snapshots
and commit the resulting changes
Signed-off-by: Oleg Tsymbal <dzirg44@gmail.com>
Done. |
Great, checks are passing! I've left some final touches, and we can merge after they're fixed! |
Signed-off-by: Oleg Tsymbal <dzirg44@gmail.com>
Changed! Thank you for mentoring! |
Thanks for the contribution! |
According to the #6227 I implemented helm api endpoint configuration.
I am not sure in the current implementation, because it looks a "little bit" weird ))
But I couldn't make up something better.
Also I am not so confident in grammar and will be glad to fix my mistakes.