enhancement(kafka source): Support Kafka headers in Kafka source #7030
Conversation
Signed-off-by: Daniil Gitelson <daniil.guit@gmail.com>
Signed-off-by: Daniil Gitelson <daniil.guit@gmail.com>
Signed-off-by: Daniil Gitelson <daniil.guit@gmail.com>
Signed-off-by: Daniil Gitelson <daniil.guit@gmail.com>
Signed-off-by: Daniil Gitelson <daniil.guit@gmail.com>
Signed-off-by: Daniil Gitelson <daniil.guit@gmail.com>
Kafka header parsing tweaks Co-authored-by: Bruce Guenter <bruce@untroubled.org> Signed-off-by: Daniil Gitelson <daniil.guit@gmail.com>
jszwedko
requested review from
a team,
prognant and
bruceg
and removed request for
a team
| } | ||
| } | ||
| } | ||
| log.insert(headers_key, Value::from(headers_map)); |
There was a problem hiding this comment.
I think this will add a new field even if headers_map is empty. If that's the case I would say we should avoid it.
There was a problem hiding this comment.
🤔 I could see it either way. I think it is nice to have headers consistently defined for all events, even if they don't have headers, than conditionally leave out that field.
There was a problem hiding this comment.
@prognant do you feel strongly about it? Otherwise my preference is to leave it so that it is consistently defined for all events coming from Kafka.
There was a problem hiding this comment.
Indeed, consistently having the field set, even with an empty value, could make sense, anyway I lack experience on the desired behaviour in such circumstances, so I better trust your judgement there 👍
Brings #6815 up-to-date with master.