enhancement(helm platform): additional labels for Prometheus Operator #7474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nlamirault
commented
May 15, 2021
nlamirault
commented
- enhancement(podmonitor.yaml and values.yaml): Added additional labels feature for PodMonitor for Prometheus Operator.
Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>
nlamirault
changed the title
nlamirault
changed the title
nlamirault
changed the title
spencergilbert
requested changes
May 17, 2021
There was a problem hiding this comment.
Thanks @nlamirault definitely useful to allow - two suggested changes to the comments just for clarity.
|
@binarylogic should we add a |
|
Yes, I would add it here. That will sync it across everything. |
Link seems broken @binarylogic |
Sorry @nlamirault that was for me, private config repo - I'm adding a |
|
@nlamirault after running down some rabbit holes... https://github.com/timberio/vector/blob/master/.github/semantic.yml#L79 |
spencergilbert
changed the title
nlamirault
requested review from
a team and
jszwedko
and removed request for
a team
JeanMertz
approved these changes
May 31, 2021
Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>
spencergilbert
approved these changes
Jun 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.