Return the created PR from the action #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Return the PR number and URL so that we can use them in other actions
timbertson
approved these changes
Feb 18, 2021
Comment on lines
+16
to
+19
| console.log(`Setting output pr_number=${pr.number}`) | ||
| core.setOutput('pr_number', pr.number.toString()) | ||
| console.log(`Setting output pr_url=${pr.url}`) | ||
| core.setOutput('pr_url', pr.url) |
There was a problem hiding this comment.
Nit: we can drop the logging lines, we already log the PR URL when we create/update it
There was a problem hiding this comment.
I guess it depends how much you trust the program.
Since Github has no validation on any output, you can specify steps.upgrade.outputs.pr and it won't error, it can be hard to trace issues especially since the setting of this output is conditional.
I don't mind removing them, but i have found it helpful when working with other actions to know what they are doing
There was a problem hiding this comment.
Ah yep, so it's more about debugging the keys that are being set rather than the values. Makes sense 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Return the PR number and URL so that we can use them in other actions
My current use case for this is that i want to assign the PR to people and add labels, it's easy to do this in other steps if i know what the PR is, otherwise i have to go and look it up again