Skip to content
This repository has been archived by the owner on Feb 4, 2022. It is now read-only.

Remove ViewTemplate auto_fetch config option #99

Closed
johanjanssens opened this issue May 26, 2016 · 0 comments · Fixed by #100
Closed

Remove ViewTemplate auto_fetch config option #99

johanjanssens opened this issue May 26, 2016 · 0 comments · Fixed by #100
Labels
refactor

Comments

@johanjanssens
Copy link
Member

johanjanssens commented May 26, 2016 •
edited
Loading

Always let the view fetch the model data. In case this is not required an extending view can override the _fetchData() method to provide it's own implementation.

Breaking changes:

  • If you do not want a view to auto-matically fetch data from the model you need to override the _fetchData() method.
johanjanssens added a commit that referenced this issue May 27, 2016
@johanjanssens
Issue #99: Add ViewContextInterface::getEntity()
be36daf 
- Add ViewContentInterface::getEntity() and implement getEntity/setEntity in ViewContext
- Remove ViewContextInterface::getContent()
- Remove ViewContext::setContent()
johanjanssens added a commit that referenced this issue May 27, 2016
@johanjanssens
Issue #99: Add ViewContextInterface::getEntity()
11e8dd0 
-Inject the model entity into the context
- Move the _fetchData() action callback to ViewTemplate
- Remove ViewContent::getContent() use $context->result to return the result of the rendered view
johanjanssens added a commit that referenced this issue May 27, 2016
@johanjanssens
Issue #99: Use $context->entity to retrieve the entity
a43ed65
johanjanssens added a commit that referenced this issue May 27, 2016
@johanjanssens
Issue #99: Use correct ViewContextTemplate typehint
7b7a399
johanjanssens added a commit that referenced this issue May 27, 2016
@johanjanssens
Issue #99: Remove ViewTemplate auto_fetch config option
a601c9d 




- Remove the auto_fetch config option in ViewTemplate


- Move the _fetchData() callback handler from ViewAbstract to ViewTemplate

BREAKING! If you do not want a view to auto-matically fetch data from the model you need to override the _fetchData() method
johanjanssens added a commit that referenced this issue May 27, 2016
@johanjanssens
Issue #99: Use $context->result
d4e180f
johanjanssens added a commit that referenced this issue May 27, 2016
@johanjanssens
Issue #99: Remove auto_fetch option. No longer exists.
fff7dd2
@johanjanssens johanjanssens mentioned this issue May 27, 2016
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove ViewTemplate auto_fetch config option timble/kodekit
1 participant
@johanjanssens