-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Layout refactor #10
Merged
Merged
Layout refactor #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…profiling annotations.
…diagrams backend.
Also did some minor formatting and comment.
…ir real family names.
…or layout differences come from.
…difiers. Also renamed the AxisVisibility modifier to fit the naming scheme of the old and other modifiers.
…need of the SVG extensions.
Not 100% coverage because of generated lenses. Undocumented functions do not appear in the haddock.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Layout refactor
This work splits the
Layout1
type intoLayout
andLayoutLR
.Layout
now represents a chart with one x axis and one y axis (of course this axis can be shared on both sides).LayoutLR
in addition has the ability to display two different y axis on each side of the chart.Layout1
was devided/removed, because it was a mixture of both types and allowed operations that were not wanted. In additionLayoutLR
can even display two different y axis that represent different types of data, which was not possible before.Several other changes were made along the way:
AxisVisibility
type was introduced to determine which parts of an axis shall be displayed at all. It contains three flags to turn the axis line, labels and ticks on or off._laxis_visible
was removed fromLayoutAxis
since its function is now replaced by the newAxisVisibility
type.StackedLayouts
. Each Layout now controls which axis are displayed itself. AlsoStackedLayout
supports both types of layout.All commits for this part were made in September.
Font embedding in SVGs
This pull request contains all changes from #8.
The commits for this work are on Aug 26 to Aug 29.