Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layout refactor #10

Merged
merged 82 commits into from
Oct 21, 2013
Merged

Layout refactor #10

merged 82 commits into from
Oct 21, 2013

Conversation

jbracker
Copy link
Contributor

Layout refactor

This work splits the Layout1 type into Layout and LayoutLR. Layout now represents a chart with one x axis and one y axis (of course this axis can be shared on both sides). LayoutLR in addition has the ability to display two different y axis on each side of the chart. Layout1 was devided/removed, because it was a mixture of both types and allowed operations that were not wanted. In addition LayoutLR can even display two different y axis that represent different types of data, which was not possible before.

Several other changes were made along the way:

  • AxisVisibility type was introduced to determine which parts of an axis shall be displayed at all. It contains three flags to turn the axis line, labels and ticks on or off.
  • _laxis_visible was removed from LayoutAxis since its function is now replaced by the new AxisVisibility type.
  • The compression of x labels was removed from StackedLayouts. Each Layout now controls which axis are displayed itself. Also StackedLayout supports both types of layout.
  • All tests were modified to work with the new interface and produce the same charts as before.

All commits for this part were made in September.

Font embedding in SVGs

This pull request contains all changes from #8.

The commits for this work are on Aug 26 to Aug 29.

Jan Bracker added 30 commits August 26, 2013 16:08
Also did some minor formatting and comment.
Jan Bracker added 26 commits September 13, 2013 15:14
…difiers.

Also renamed the AxisVisibility modifier to fit the naming scheme of the old and other modifiers.
Not 100% coverage because of generated lenses.
Undocumented functions do not appear in the haddock.
@jbracker jbracker mentioned this pull request Sep 16, 2013
@timbod7 timbod7 merged commit ed8b430 into timbod7:master Oct 21, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants