Cache depositTo ids between payment exports #6

timbze · Nov 30, 2021 · 5b235e7 · 5b235e7
1 parent 51af3a7
commit 5b235e7
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/plugins/quickbooks-online/src/src/Facade/QuickBooksFacade.php b/plugins/quickbooks-online/src/src/Facade/QuickBooksFacade.php
@@ -791,6 +791,7 @@ private function getAccounts(DataService $dataService): array
         return $activeAccounts;
     }
 
+    private $depositToCache = [];
     private function getDepositToIdForPayment(string $paymentMethodName, DataService $dataService, PluginData $pluginData): ?string
     {
         $links = $pluginData->paymentTypeWithAccountLink;
@@ -802,11 +803,16 @@ private function getDepositToIdForPayment(string $paymentMethodName, DataService
             $payType = trim($methodAcct[0]);
             if ($payType != $paymentMethodName) continue;
 
+            $cachedId = $this->depositToCache[$payType];
+            if ($cachedId)
+                return $cachedId;
+
             $depositAcct = trim($methodAcct[1]);
             $accounts = $this->dataServiceQuery($dataService, "SELECT * FROM Account WHERE Name = '$depositAcct' AND (AccountType = 'Bank' OR AccountType = 'Other Current Asset')",
                 true);
             if ($accounts) {
                 $id = $accounts[0]['Id'];
+                $this->depositToCache[$payType] = $id;
                 $this->logger->debug("Found account for payment \"deposit to\" with Id $id");
                 return $id;
             } else {