Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Registering dynamic children not working #64

Closed
timc1 opened this issue Oct 16, 2021 · 0 comments · Fixed by #71
Closed

Registering dynamic children not working #64

timc1 opened this issue Oct 16, 2021 · 0 comments · Fixed by #71
Assignees
Labels
bug Something isn't working

Comments

@timc1
Copy link
Owner

timc1 commented Oct 16, 2021

When adding children actions dynamically to existing parent actions, we need to update the parent action.children list.

https://github.com/timc1/kbar/blob/main/src/useStore.tsx#L46-L58

@timc1 timc1 added the bug Something isn't working label Oct 16, 2021
@timc1 timc1 changed the title Dynamic children not working Registering dynamic children not working Oct 16, 2021
@timc1 timc1 self-assigned this Oct 16, 2021
@tommoor tommoor assigned tommoor and unassigned timc1 Oct 17, 2021
tommoor added a commit that referenced this issue Oct 17, 2021
@tommoor tommoor assigned timc1 and unassigned tommoor Oct 19, 2021
@timc1 timc1 closed this as completed in #71 Oct 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants