Enable tracing.async-acks by default

Signed-off-by: Arunprasad Rajkumar <ar.arunprasad@gmail.com>
timescale · Sep 17, 2022 · 3d8b901 · 3d8b901
1 parent a874bcd
commit 3d8b901
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -21,6 +21,7 @@ We use the following categories for changes:
   requests [#1205]
 - Add cmd flag `web.auth.ignore-path` to skip http paths from authentication [#1637]
 - Add cmd flag `tracing.streaming-span-writer` to enable/disable streaming span writer. It is enabled by default. [#1633].
+- Enable tracing.async-acks by default [#1633].
 
 ### Changed
 - Log throughput in the same line for samples, spans and metric metadata [#1643]

diff --git a/docs/configuration.md b/docs/configuration.md
@@ -50,7 +50,7 @@ The following subsections cover all CLI flags which promscale supports. You can
 | thanos.store-api.server-address |             string             |     "" (disabled)     | Address to listen on for Thanos Store API endpoints.                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                    |
 | tracing.otlp.server-address     |             string             |        ":9202"        | GRPC server address to listen on for Jaeger and OTEL traces(DEPRECATED: use `tracing.grpc.server-address` instead).                                                                                                                                                                                                                                                                                                                                                                                                                                                                     |
 | tracing.grpc.server-address     |             string             |        ":9202"        | GRPC server address to listen on for Jaeger and OTEL traces.                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                            |
-| tracing.async-acks              |            boolean             |         false         | Acknowledge asynchronous inserts. If this is true, the inserter will not wait after insertion of traces data in the database. This increases throughput at the cost of a small chance of data loss.                                                                                                                                                                                                                                                                                                                                                                                     |
+| tracing.async-acks              |            boolean             |         true          | Acknowledge asynchronous inserts. If this is true, the inserter will not wait after insertion of traces data in the database. This increases throughput at the cost of a small chance of data loss.                                                                                                                                                                                                                                                                                                                                                                                     |
 | tracing.max-batch-size          |            integer             |         5000          | Maximum size of trace batch that is written to DB.                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                      |
 | tracing.batch-timeout           |            duration            |         250ms         | Timeout after new trace batch is created.                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                               |
 | tracing.batch-workers           |            integer             | num of available cpus | Number of workers responsible for creating trace batches. Defaults to number of CPUs.                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                   |

diff --git a/pkg/pgclient/config.go b/pkg/pgclient/config.go
@@ -98,7 +98,7 @@ func ParseFlags(fs *flag.FlagSet, cfg *Config) *Config {
 	fs.BoolVar(&cfg.EnableStatementsCache, "db.statements-cache", defaultDbStatementsCache, "Whether database connection pool should use cached prepared statements. "+
 		"Disable if using PgBouncer")
 	fs.BoolVar(&cfg.MetricsAsyncAcks, "metrics.async-acks", false, "Acknowledge asynchronous inserts. If this is true, the inserter will not wait after insertion of metric data in the database. This increases throughput at the cost of a small chance of data loss.")
-	fs.BoolVar(&cfg.TracesAsyncAcks, "tracing.async-acks", false, "Acknowledge asynchronous inserts. If this is true, the inserter will not wait after insertion of traces data in the database. This increases throughput at the cost of a small chance of data loss.")
+	fs.BoolVar(&cfg.TracesAsyncAcks, "tracing.async-acks", true, "Acknowledge asynchronous inserts. If this is true, the inserter will not wait after insertion of traces data in the database. This increases throughput at the cost of a small chance of data loss.")
 	fs.IntVar(&cfg.TracesMaxBatchSize, "tracing.max-batch-size", trace.DefaultBatchSize, "Maximum size of trace batch that is written to DB")
 	fs.DurationVar(&cfg.TracesBatchTimeout, "tracing.batch-timeout", trace.DefaultBatchTimeout, "Timeout after new trace batch is created")
 	fs.IntVar(&cfg.TracesBatchWorkers, "tracing.batch-workers", trace.DefaultBatchWorkers, "Number of workers responsible for creating trace batches. Defaults to number of CPUs.")