Skip to content
This repository has been archived by the owner on Apr 2, 2024. It is now read-only.

Commit

Permalink
Ensure we pin the container image of Promscale to an actual version
Browse files Browse the repository at this point in the history
- Change how the container image information is structures in values.yaml
- Take the default container image tag from Chart.yaml, but allow override.
- Fix github actions pipeline
  • Loading branch information
nhudson committed Jul 27, 2022
1 parent 552242e commit 60062e0
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 6 deletions.
3 changes: 2 additions & 1 deletion .github/workflows/helm.yml
Expand Up @@ -71,6 +71,7 @@ jobs:
helm repo update
helm install \
--set replicaCount=1 \
--set image.tag=pg14.4-ts2.7.2-p0 \
timescaledb timescale/timescaledb-single
kubectl rollout status statefulset timescaledb
Expand Down Expand Up @@ -110,7 +111,7 @@ jobs:
run: |
mkdir -p chart_release
helm package deploy/helm-chart -d chart_release/
helm plugin install https://github.com/hypnoglow/helm-s3.git
helm plugin install https://github.com/hypnoglow/helm-s3.git
helm repo add tscharts s3://charts.timescale.com
helm s3 push chart_release/* tscharts --acl public-read --relative --dry-run
Expand Down
4 changes: 2 additions & 2 deletions deploy/helm-chart/templates/deployment-promscale.yaml
Expand Up @@ -33,8 +33,8 @@ spec:
{{- end }}
spec:
containers:
- image: {{ .Values.image }}
imagePullPolicy: {{ .Values.imagePullPolicy }}
- image: {{ .Values.image.repository }}:{{ default .Chart.AppVersion .Values.image.tag }}
imagePullPolicy: {{ .Values.image.pullPolicy }}
name: promscale
args:
- "-config=/etc/promscale/config.yaml"
Expand Down
9 changes: 7 additions & 2 deletions deploy/helm-chart/values.yaml
@@ -1,5 +1,10 @@
image: timescale/promscale
imagePullPolicy: IfNotPresent
image:
repository: timescale/promscale
# The default will come from appVersion in Chart.yaml, if you wish to
# override that value then set the tag version here.
tag:
pullPolicy: IfNotPresent

# number of connector pods to spawn
replicaCount: 1

Expand Down
2 changes: 1 addition & 1 deletion deploy/static/deploy.yaml
Expand Up @@ -106,7 +106,7 @@ spec:
prometheus.io/scrape: "true"
spec:
containers:
- image: timescale/promscale
- image: timescale/promscale:0.13.0
imagePullPolicy: IfNotPresent
name: promscale
args:
Expand Down

0 comments on commit 60062e0

Please sign in to comment.