Skip to content
This repository has been archived by the owner on Apr 2, 2024. It is now read-only.

Commit

Permalink
Remove flaky PromscaleCacheTooSmall alert
Browse files Browse the repository at this point in the history
This commit removes the alert PromscaleCacheTooSmall which is flaky and fires during same cause as `PromscaleCacheHighNumberOfEvictions`.

Fixes #1356.

Signed-off-by: Arunprasad Rajkumar <ar.arunprasad@gmail.com>
  • Loading branch information
arajkumar committed Jul 20, 2022
1 parent e173fd1 commit aa33000
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 65 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Expand Up @@ -30,6 +30,7 @@ We use the following categories for changes:
- Refine check for existence of `prom_schema_migrations` table [#1452]
- Do not run rules-manager in `-db.read-only` mode [#1451]
- Fix underlying metric(`promscale_sql_database_chunks_count`) which leads to false positive firing of PromscaleCompressionLow alert [#1494]
- Remove flaky PromscaleCacheTooSmall alert [#1498]

## [0.12.1] - 2022-06-29

Expand Down
27 changes: 3 additions & 24 deletions deploy/helm-chart/templates/prometheus-rule.yaml
Expand Up @@ -183,37 +183,16 @@ spec:
- alert: PromscaleCacheHighNumberOfEvictions
expr: |
(
sum by (job, instance, name, type) (
rate(promscale_cache_evictions_total[5m])
)
/
sum by (job, instance, name, type) (
promscale_cache_capacity_elements
)
rate(promscale_cache_evictions_total[5m])
/
promscale_cache_capacity_elements
) > 0.2
labels:
severity: warning
annotations:
summary: High cache eviction in Promscale.
description: "Promscale {{ $labels.name }} is evicting at {{ $value }} entries a second."
runbook_url: https://github.com/timescale/promscale/blob/master/docs/runbooks/PromscaleCacheHighNumberOfEvictions.md
- alert: PromscaleCacheTooSmall
expr: |
(
sum by (job, instance, type, name) (
rate(promscale_cache_query_hits_total[5m])
)
/
sum by (job, instance, type, name) (
rate(promscale_cache_queries_total[5m])
)
) < 0.9
labels:
severity: warning
annotations:
summary: High cache eviction in Promscale.
description: "Promscale {{ $labels.name }} has a hit ratio of {{ $value | humanizePercentage }}."
runbook_url: https://github.com/timescale/promscale/blob/master/docs/runbooks/PromscaleCacheTooSmall.md
- name: promscale-database-connection
rules:
- alert: PromscaleDBHighErrorRate
Expand Down
27 changes: 3 additions & 24 deletions docs/mixin/alerts/alerts.yaml
Expand Up @@ -172,37 +172,16 @@ groups:
- alert: PromscaleCacheHighNumberOfEvictions
expr: |
(
sum by (job, instance, name, type) (
rate(promscale_cache_evictions_total[5m])
)
/
sum by (job, instance, name, type) (
promscale_cache_capacity_elements
)
rate(promscale_cache_evictions_total[5m])
/
promscale_cache_capacity_elements
) > 0.2
labels:
severity: warning
annotations:
summary: High cache eviction in Promscale.
description: "Promscale {{ $labels.name }} is evicting at {{ $value }} entries a second."
runbook_url: https://github.com/timescale/promscale/blob/master/docs/runbooks/PromscaleCacheHighNumberOfEvictions.md
- alert: PromscaleCacheTooSmall
expr: |
(
sum by (job, instance, type, name) (
rate(promscale_cache_query_hits_total[5m])
)
/
sum by (job, instance, type, name) (
rate(promscale_cache_queries_total[5m])
)
) < 0.9
labels:
severity: warning
annotations:
summary: High cache eviction in Promscale.
description: "Promscale {{ $labels.name }} has a hit ratio of {{ $value | humanizePercentage }}."
runbook_url: https://github.com/timescale/promscale/blob/master/docs/runbooks/PromscaleCacheTooSmall.md
- name: promscale-database-connection
rules:
- alert: PromscaleDBHighErrorRate
Expand Down
17 changes: 0 additions & 17 deletions docs/runbooks/PromscaleCacheTooSmall.md

This file was deleted.

0 comments on commit aa33000

Please sign in to comment.