Change idempotent behavior for dev releases.

On dev versions idempotent scripts always re-run since
we don't bump versions for idempotent changes.

Also add tests for development on dev versions.

pkg/pgmodel/end_to_end_tests/migrate_test.go

@@ -101,6 +101,16 @@ func TestMigrationLib(t *testing.T) {
 			"migration 0.10.0=2",
 			"idempotent 1",
 			"idempotent 2",
+			"idempotent 1",
+			"idempotent 2",
+			"idempotent 1",
+			"idempotent 2",
+			"migration 0.10.1=1",
+			"idempotent 1",
+			"idempotent 2",
+			"migration 0.10.1=2",
+			"idempotent 1",
+			"idempotent 2",
 		}
 
 		mig := pgmodel.NewMigrator(db, test_migrations.MigrationFiles, testTOC)
@@ -126,7 +136,7 @@ func TestMigrationLib(t *testing.T) {
 		}
 		verifyLogs(t, db, expected[0:6])
 
-		//does nothing
+		//does nothing, since non-dev and same version as before
 		err = mig.Migrate(semver.MustParse("0.2.0"))
 		if err != nil {
 			t.Fatal(err)
@@ -153,5 +163,32 @@ func TestMigrationLib(t *testing.T) {
 			t.Fatal(err)
 		}
 		verifyLogs(t, db, expected[0:13])
+
+		//upgrading version, idempotent files apply
+		err = mig.Migrate(semver.MustParse("0.10.1-dev"))
+		if err != nil {
+			t.Fatal(err)
+		}
+		verifyLogs(t, db, expected[0:15])
+
+		//even if no version upgrades, idempotent files apply if it's a dev version
+		err = mig.Migrate(semver.MustParse("0.10.1-dev"))
+		if err != nil {
+			t.Fatal(err)
+		}
+		verifyLogs(t, db, expected[0:17])
+
+		//now test logic within a release:
+		err = mig.Migrate(semver.MustParse("0.10.1-dev.1"))
+		if err != nil {
+			t.Fatal(err)
+		}
+		verifyLogs(t, db, expected[0:20])
+
+		err = mig.Migrate(semver.MustParse("0.10.1-dev.2"))
+		if err != nil {
+			t.Fatal(err)
+		}
+		verifyLogs(t, db, expected[0:23])
 	})
 }

pkg/pgmodel/migrate.go

@@ -139,8 +139,32 @@ func (t *Migrator) Migrate(appVersion semver.Version) error {
 		return fmt.Errorf("failed to get the version from database: %w", err)
 	}
 
-	// If already at correct version, nothing to migrate.
+	// If already at correct version, nothing to migrate on proper release.
+	// On dev versions, idempotent files need to be reapplied.
 	if dbVersion.Compare(appVersion) == 0 {
+		devRelease := false
+		for _, pre := range appVersion.Pre {
+			if pre.String() == "dev" {
+				devRelease = true
+			}
+		}
+
+		if devRelease {
+			tx, err := t.db.Begin(context.Background())
+			if err != nil {
+				return fmt.Errorf("unable to start transaction: %w", err)
+			}
+			defer func() {
+				_ = tx.Rollback(context.Background())
+			}()
+			if err = t.execMigrationFiles(tx, idempotentScripts); err != nil {
+				return err
+			}
+			if err = tx.Commit(context.Background()); err != nil {
+				return fmt.Errorf("unable to commit migration transaction: %w", err)
+			}
+			return nil
+		}
 		return nil
 	}
 
@@ -414,7 +438,7 @@ func (t *Migrator) upgradeVersion(tx pgx.Tx, from, to semver.Version) error {
 
 	for _, v := range versions {
 		//When comparing to the latest version use >= (INCLUSIVE). A migration file
-		//that's marked as version X is part of that version.
+		//that's marked as version X is part of that version
 		if from.Compare(v) < 0 && to.Compare(v) >= 0 {
 			filename := versionMap[v.String()]
 			if err = t.execMigrationFile(tx, filename); err != nil {