This repository has been archived by the owner on Apr 2, 2024. It is now read-only.
Fix passing of async flag #1008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were two problems with async flag. First it was present in two Config structs and parsed in the struct that is not being used. Second was that async flag was not passed when creating sub-config structure. Effectively result in async flag not being applied. This should fix that.
niksajakovljevic
requested review from
antekresic,
Harkishen-Singh and
a team
as code owners
antekresic
approved these changes
Jan 3, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were two problems with async flag. First it was present
in two Config structs and parsed in the struct that is not being
used. Second was that async flag was not passed when creating
sub-config structure. This resulted in async flag not being
applied.
Also removing some unused config.
Hopefully in future we will increase test coverage for flags and configs so we catch this easily.
It seems we would need a decent amount of refactoring to support these tests so I'll leave it for another PR.