This repository has been archived by the owner on Apr 2, 2024. It is now read-only.
Fix metric info cache loading when using query path #1095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the recent optimization, we have added metric IDs to metric cache but when running queries on metrics that exist before the ingestion path generates the cache, cache will be created with invalid metric ID values. This change fixes that and adds end-to-end test for verifying that cache is properly generated when this situation occurs.
VineethReddy02
added
the
Performance
cevian
approved these changes
Feb 1, 2022
Harkishen-Singh
approved these changes
Feb 2, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With the recent optimization, we have added metric IDs to metric cache
but when running queries on metrics that exist before the ingestion path
generates the cache, cache will be created with invalid metric ID values.
This change fixes that and adds end-to-end test for verifying that
cache is properly generated when this situation occurs.
Merge requirements
Please take into account the following non-code changes that you may need to make with your PR: