This repository has been archived by the owner on Apr 2, 2024. It is now read-only.
Increase visibility into trace ingest #1152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niksajakovljevic
requested review from
antekresic,
Harkishen-Singh and
a team
as code owners
Harkishen-Singh
suggested changes
Feb 16, 2022
There was a problem hiding this comment.
Some changes are required after this PR is merged with #1113
niksajakovljevic
force-pushed
the
niksa/metrics-for-trace-ingest
branch
2 times, most recently
from
f2eb14f
to
7c2e775
Compare
Harkishen-Singh
suggested changes
Feb 16, 2022
niksajakovljevic
force-pushed
the
niksa/metrics-for-trace-ingest
branch
from
7c2e775
to
372acbb
Compare
Harkishen-Singh
approved these changes
Feb 16, 2022
niksajakovljevic
force-pushed
the
niksa/metrics-for-trace-ingest
branch
from
372acbb
to
bc8bfdf
Compare
antekresic
reviewed
Feb 16, 2022
niksajakovljevic
force-pushed
the
niksa/metrics-for-trace-ingest
branch
from
bc8bfdf
to
454e257
Compare
niksajakovljevic
force-pushed
the
niksa/metrics-for-trace-ingest
branch
from
454e257
to
d199b66
Compare
antekresic
approved these changes
Feb 16, 2022
Add few more metrics that will give us more insight into ingest. Mainly we want to see how big our insert batches are and also the time it takes to insert various trace related objects. This should help us in finding weak spots.
niksajakovljevic
force-pushed
the
niksa/metrics-for-trace-ingest
branch
from
d199b66
to
558e135
Compare
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add few more metrics that will give us more insight into ingest.
Mainly we want to see how big our insert batches are and also the time it
takes to insert various trace related objects. This should help
us in finding weak spots.