This repository has been archived by the owner on Apr 2, 2024. It is now read-only.
Fix panic in prom-migrator proto-enum registration #1375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Harkishen-Singh
force-pushed
the
fix_prom_migrator_proto_err
branch
from
dd550a3
to
439e6b7
Compare
Harkishen-Singh
force-pushed
the
fix_prom_migrator_proto_err
branch
from
439e6b7
to
3747f8b
Compare
Harkishen-Singh
force-pushed
the
fix_prom_migrator_proto_err
branch
from
3747f8b
to
1f2bdc8
Compare
Signed-off-by: Harkishen-Singh <harkishensingh@hotmail.com> This commit fixes the duplicate proto enum registration panic in prom-migrator. This is done by removing all imports from Promscale which prevents the duplicate registration of the commonly imported `prompb` package by both Promscale and Prom-migrator.
Harkishen-Singh
force-pushed
the
fix_prom_migrator_proto_err
branch
from
1f2bdc8
to
5350249
Compare
niksajakovljevic
approved these changes
May 26, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Harkishen-Singh harkishensingh@hotmail.com
This commit fixes the duplicate proto enum registration panic
in prom-migrator. This is done by removing all imports from Promscale
which prevents the duplicate registration of the commonly imported
prompbpackage by both Promscale and Prom-migrator.Description
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.
Merge requirements
Please take into account the following non-code changes that you may need to make with your PR: