This repository has been archived by the owner on Apr 2, 2024. It is now read-only.
Add extraEnvFrom value to helm chart #1473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raphaelzoellner
requested review from
a team,
cevian and
JamesGuthrie
as code owners
paulfantom
approved these changes
Jul 7, 2022
paulfantom
requested review from
a team
and removed request for
cevian and
JamesGuthrie
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This Merge request adds a
extraEnvFromvalue to the helm chart allowing to set environment variables to the promscale pod's container by referencing e.g. secrets or configmaps.This may for instance be used to define a secret environment variable for promscales basic auth and set
PROMSCALE_WEB_AUTH_USERNAMEandPROMSCALE_WEB_AUTH_PASSWORD.