This repository has been archived by the owner on Apr 2, 2024. It is now read-only.
Improve trace id query #1626
Merged
Improve trace id query #1626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
|
@arajkumar yes it's still very relevant |
cevian
force-pushed
the
improve_trace_id_query
branch
from
d587f05
to
3ecd4f5
Compare
Previously, the trace id query did a simple join between the trace, events, links tables on trace/spanid WITHOUT using our time-frame limiting logic. This commit uses a subquery on the span table to get a time-range first before doing all the other joins, which allows chunk exclusion to limit the amount of data fetched from the links and events tables. Fixes #1540
cevian
force-pushed
the
improve_trace_id_query
branch
from
3ecd4f5
to
3228c5f
Compare
Combine queries together.
Other parts of the subquery are not needed when getting the time for a given traceid
cevian
force-pushed
the
improve_trace_id_query
branch
from
3228c5f
to
d5ed3c0
Compare
alejandrodnm
approved these changes
Oct 17, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improves trace id query performance.
Fixes #1540.
Blocked by #1621. After #1621 is resolved, rebase and reapply these patches. Keep as draft until then.
Merge requirements
Please take into account the following non-code changes that you may need to make with your PR: