This repository has been archived by the owner on Apr 2, 2024. It is now read-only.
Add a database connection pool for maintenance jobs #1657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgpruitt
force-pushed
the
john/maintenance-pool
branch
8 times, most recently
from
f228c92
to
20f8250
Compare
antekresic
suggested changes
Sep 23, 2022
alejandrodnm
suggested changes
Sep 23, 2022
jgpruitt
force-pushed
the
john/maintenance-pool
branch
from
20f8250
to
fea871e
Compare
alejandrodnm
approved these changes
Sep 27, 2022
antekresic
approved these changes
Sep 27, 2022
Creates a separate pool of database connections for the telemetry and vacuum engines. We don't want maintenance jobs stealing from the other pools, especially the writer pool. The maintenance pool defaults to 5 connections. The logic for calculating database pool sizes was revamped now that there are 3 pools. Tests were added.
jgpruitt
force-pushed
the
john/maintenance-pool
branch
from
fea871e
to
cb6b4e4
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding a dedicated pool of database connections for use by maintenance jobs such as the telemetry and vacuum engines.
Merge requirements
Please take into account the following non-code changes that you may need to make with your PR: