This repository has been archived by the owner on Apr 2, 2024. It is now read-only.
Wrap extension upgrades in a transaction #1665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgpruitt
force-pushed
the
john/tx-upgrade
branch
from
ae30ca5
to
63123fe
Compare
alejandrodnm
approved these changes
Sep 23, 2022
antekresic
suggested changes
Sep 23, 2022
In some cases, an extension upgrade is a multistep process. This change wraps some of those steps in an explicit transaction. Specifically, we don't want a failure to result in the extension being left at version 0.0.0
jgpruitt
force-pushed
the
john/tx-upgrade
branch
from
63123fe
to
3a7a04b
Compare
antekresic
approved these changes
Sep 27, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In some cases, an extension upgrade is a multi-step process. This change wraps some of those steps in an explicit transaction. Specifically, we don't want a failure to result in the extension being left at version 0.0.0
Merge requirements
Please take into account the following non-code changes that you may need to make with your PR: