This repository has been archived by the owner on Apr 2, 2024. It is now read-only.
Fix series cache growth #1705
Merged
Fix series cache growth #1705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niksajakovljevic
added
the
Performance
niksajakovljevic
force-pushed
the
niksa/fix-cache-growth
branch
3 times, most recently
from
c880466
to
c69de1a
Compare
niksajakovljevic
force-pushed
the
niksa/fix-cache-growth
branch
from
c69de1a
to
002153e
Compare
niksajakovljevic
requested review from
alejandrodnm,
arajkumar and
Harkishen-Singh
alejandrodnm
approved these changes
Oct 21, 2022
Approach is using timestamps to have better understanding on what elements are getting evicted. If we see an eviction of recently used/inserted element (defined with evictionMaxAge) we will attempt to grow the cache. `evictionMaxAge` defines max age where we allow evictions and don't grow the cache. This fixes the problem with series cache growth. Main idea here is not to allow evictions of recently used elements but to try to grow cache instead.
niksajakovljevic
force-pushed
the
niksa/fix-cache-growth
branch
from
002153e
to
5e57ae3
Compare
This was referenced Nov 29, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Approach is using timestamps to have better understanding on what elements are getting evicted.
If we see an eviction of recently used/inserted element (defined with
evictionMaxAge) we will attempt to grow the cache.evictionMaxAgedefines max age where we are doing evictions and not growing the cache.We don't use additional memory to track timestamps but re-use existing field by bit packing data into
uint32.Closes #1389