Skip to content
This repository has been archived by the owner on Apr 2, 2024. It is now read-only.

More maintenance jobs metrics #1745

Merged
merged 1 commit into from Nov 9, 2022
Merged

Conversation

sumerman
Copy link
Contributor

@sumerman sumerman commented Nov 8, 2022

Description

Collecting job stats for each maintenance job type and signal.

This is a matching PR for timescale/promscale_extension#555

Merge requirements

Please take into account the following non-code changes that you may need to make with your PR:

  • CHANGELOG entry for user-facing changes
  • Updated the relevant documentation

@sumerman sumerman marked this pull request as ready for review November 8, 2022 22:26
@sumerman sumerman requested review from a team as code owners November 8, 2022 22:26
@sumerman sumerman changed the title Maintenance jobs metrics without backend local side channel More maintenance jobs metrics Nov 8, 2022
Copy link
Contributor

@niksajakovljevic niksajakovljevic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great for adding histograms!
I'd only ask for adding e2e tests so we can validate that given query and metrics is working. Checking this e2e test as ref: database_metrics_test.go

- A test has been moved to the extension repository and
  another test was adjusted to not over-specify the number of jobs in a
  metrics test.
- Two new families of metrics were added to the dashboard
- Histograms are now supported in database-reported metrics
@sumerman sumerman force-pushed the vm/job-metrics-no-sidechannel branch from 0ebf610 to c21884e Compare November 9, 2022 16:06
@sumerman sumerman merged commit fee0e1f into master Nov 9, 2022
@sumerman sumerman deleted the vm/job-metrics-no-sidechannel branch November 9, 2022 18:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants