This repository has been archived by the owner on Apr 2, 2024. It is now read-only.
Fix _prom_catalog.metric_view() function on non-tsdb installs #958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesGuthrie
force-pushed
the
jg/fix-metric-view
branch
from
f967dd0
to
58f40be
Compare
jgpruitt
approved these changes
Dec 8, 2021
Harkishen-Singh
approved these changes
Dec 10, 2021
The metric_view function would fail when tsdb is not installed with the following error: column reference "id" is ambiguous The fix is to use the full qualifier of the aliased subselect. Fixes #738
JamesGuthrie
force-pushed
the
jg/fix-metric-view
branch
from
58f40be
to
371cc7f
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The metric_view function would fail when tsdb is not installed with the
following error:
column reference "id" is ambiguous
The fix is to use the full qualifier of the aliased subselect.
Fixes #738
Note: I did not add a test for this fix as I was unable to reproduce the issue in our testing framework. I would appreciate assistance with adding a test for this.