Prevent unnecessary rebuilds using Cargo in root #520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The [Cargo docs](https://doc.rust-lang.org/cargo/reference/config.html#hierarchical-structure) specify that Cargo config files are looked for in each parent directory, so including the exact same config file in the extension directory and its parent directory is unnecessary. Config file duplication results in `cargo test` in the root directory building Toolkit from scratch twice, since Cargo invalidates previously built dependencies whenever it uses a new config file (even if they are semantically identical).
rtwalker
approved these changes
Sep 6, 2022
Me too! THANK YOU!!! |
epgts
approved these changes
Sep 6, 2022
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
.cargo/configandextension/.cargo/configare the same file (except for whitespace differences).The Cargo docs specify that Cargo config files are looked for in each parent directory, so including the exact same config file in the
extension/directory and its parent directory is unnecessary.The pgx README says:
Config file duplication results in
cargo testin the root directory building Toolkit from scratch twice, since Cargo invalidates previously built dependencies whenever it uses a new config file (even if they are semantically identical).