Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add timezone support to time_bucket #4642

Merged
merged 1 commit into from Aug 25, 2022
Merged

Add timezone support to time_bucket #4642

merged 1 commit into from Aug 25, 2022

Conversation

svenklemm
Copy link
Member

@svenklemm svenklemm commented Aug 22, 2022 •
edited

This patch adds a new function time_bucket(period,timestamp,timezone)
which supports bucketing for arbitrary timezones.

Fixes #414

@svenklemm svenklemm self-assigned this Aug 22, 2022
@svenklemm svenklemm added this to the TimescaleDB 2.8 milestone Aug 22, 2022
@svenklemm svenklemm force-pushed the time_bucket_timezone branch 2 times, most recently from 0e674d2 to e7ed0ff Compare August 22, 2022 19:02
@codecov
Copy link

codecov bot commented Aug 22, 2022 •
edited

Codecov Report

Merging #4642 (663a756) into main (0b76a8e) will increase coverage by 0.02%.
The diff coverage is 92.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4642      +/-   ##
==========================================
+ Coverage   90.79%   90.81%   +0.02%     
==========================================
  Files         221      224       +3     
  Lines       41003    42191    +1188     
==========================================
+ Hits        37228    38317    +1089     
- Misses       3775     3874      +99
Impacted Files Coverage Δ
src/chunk.h 100.00% <ø> (ø)
src/hypertable_restrict_info.c 95.84% <ø> (ø)
src/planner/planner.h 100.00% <ø> (ø)
src/ts_catalog/catalog.c 83.81% <ø> (ø)
src/ts_catalog/catalog.h 100.00% <ø> (ø)
src/ts_catalog/continuous_agg.h 100.00% <ø> (ø)
src/utils.h 82.60% <ø> (ø)
tsl/src/continuous_aggs/insert.c 90.00% <ø> (ø)
tsl/src/continuous_aggs/options.c 95.79% <ø> (ø)
tsl/src/fdw/data_node_chunk_assignment.c 97.61% <ø> (ø)
... and 71 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc145b7...663a756. Read the comment docs.

akuzm
akuzm reviewed Aug 23, 2022
View reviewed changes
src/func_cache.c
static Expr *
time_bucket_tz_sort_transform(FuncExpr *func)
{
Assert(list_length(func->args) == 5);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the tests are missing.

@charislam charislam mentioned this pull request Aug 23, 2022
Closed
4 tasks
@svenklemm svenklemm force-pushed the time_bucket_timezone branch 9 times, most recently from ff186bc to 49446b2 Compare August 24, 2022 02:01
@konskov konskov self-requested a review August 24, 2022 18:39
@svenklemm svenklemm force-pushed the time_bucket_timezone branch 3 times, most recently from dc1fe0b to bac4316 Compare August 25, 2022 10:12
@svenklemm
Add timezone support to time_bucket
663a756 
This patch adds a new function time_bucket(period,timestamp,timezone)
which supports bucketing for arbitrary timezones.
@svenklemm svenklemm merged commit 5d934ba into timescale:main Aug 25, 2022
@charislam charislam mentioned this pull request Aug 29, 2022
Closed
svenklemm added a commit to svenklemm/timescaledb that referenced this pull request Aug 31, 2022
@svenklemm
Release 2.8.0
8be3214 
This release adds major new features since the 2.7.2 release.
We deem it moderate priority for upgrading.

This release includes these noteworthy features:

* time_bucket now supports bucketing by month, year and timezone
* Improve performance of bulk SELECT and COPY for distributed hypertables
* 1 step CAgg policy management
* Migrate Continuous Aggregates to the new format

**Features**
* timescale#4188 Use COPY protocol in row-by-row fetcher
* timescale#4307 Mark partialize_agg as parallel safe
* timescale#4380 Enable chunk exclusion for space dimensions in UPDATE/DELETE
* timescale#4384 Add schedule_interval to policies
* timescale#4390 Faster lookup of chunks by point
* timescale#4393 Support intervals with day component when constifying now()
* timescale#4397 Support intervals with month component when constifying now()
* timescale#4405 Support ON CONFLICT ON CONSTRAINT for hypertables
* timescale#4412 Add telemetry about replication
* timescale#4415 Drop remote data when detaching data node
* timescale#4416 Handle TRUNCATE TABLE on chunks
* timescale#4425 Add parameter check_config to alter_job
* timescale#4430 Create index on Continuous Aggregates
* timescale#4439 Allow ORDER BY on continuous aggregates
* timescale#4443 Add stateful partition mappings
* timescale#4484 Use non-blocking data node connections for COPY
* timescale#4495 Support add_dimension() with existing data
* timescale#4502 Add chunks to baserel cache on chunk exclusion
* timescale#4545 Add hypertable distributed argument and defaults
* timescale#4552 Migrate Continuous Aggregates to the new format
* timescale#4556 Add runtime exclusion for hypertables
* timescale#4561 Change get_git_commit to return full commit hash
* timescale#4563 1 step CAgg policy management
* timescale#4641 Allow bucketing by month, year, century in time_bucket and time_bucket_gapfill
* timescale#4642 Add timezone support to time_bucket

**Bugfixes**
* timescale#4359 Create composite index on segmentby columns
* timescale#4374 Remove constified now() constraints from plan
* timescale#4416 Handle TRUNCATE TABLE on chunks
* timescale#4478 Synchronize chunk cache sizes
* timescale#4486 Adding boolean column with default value doesn't work on compressed table
* timescale#4512 Fix unaligned pointer access
* timescale#4519 Throw better error message on incompatible row fetcher settings
* timescale#4549 Fix dump_meta_data for windows
* timescale#4553 Fix timescaledb_post_restore GUC handling
* timescale#4573 Load TSL library on compressed_data_out call
* timescale#4575 Fix use of `get_partition_hash` and `get_partition_for_key` inside an IMMUTABLE function
* timescale#4577 Fix segfaults in compression code with corrupt data
* timescale#4580 Handle default privileges on CAggs properly
* timescale#4582 Fix assertion in GRANT .. ON ALL TABLES IN SCHEMA
* timescale#4583 Fix partitioning functions
* timescale#4589 Fix rename for distributed hypertable
* timescale#4601 Reset compression sequence when group resets
* timescale#4611 Fix a potential OOM when loading large data sets into a hypertable
* timescale#4624 Fix heap buffer overflow
* timescale#4627 Fix telemetry initialization
* timescale#4631 Ensure TSL library is loaded on database upgrades
* timescale#4646 Fix time_bucket_ng origin handling
* timescale#4647 Fix the error "SubPlan found with no parent plan" that occurred if using joins in RETURNING clause.

**Thanks**
* @AlmiS for reporting error on `get_partition_hash` executed inside an IMMUTABLE function
* @Creatation for reporting an issue with renaming hypertables
* @janko for reporting an issue when adding bool column with default value to compressed hypertable
* @jayadevanm for reporting error of TRUNCATE TABLE on compressed chunk
* @michaelkitson for reporting permission errors using default privileges on Continuous Aggregates
* @mwahlhuetter for reporting error in joins in RETURNING clause
* @ninjaltd and @mrksngl for reporting a potential OOM when loading large data sets into a hypertable
* @PBudmark for reporting an issue with dump_meta_data.sql on Windows
* @ssmoss for reporting an issue with time_bucket_ng origin handling
@svenklemm svenklemm mentioned this pull request Aug 31, 2022
Merged
svenklemm added a commit that referenced this pull request Aug 31, 2022
@svenklemm
Release 2.8.0
f432d7f 
This release adds major new features since the 2.7.2 release.
We deem it moderate priority for upgrading.

This release includes these noteworthy features:

* time_bucket now supports bucketing by month, year and timezone
* Improve performance of bulk SELECT and COPY for distributed hypertables
* 1 step CAgg policy management
* Migrate Continuous Aggregates to the new format

**Features**
* #4188 Use COPY protocol in row-by-row fetcher
* #4307 Mark partialize_agg as parallel safe
* #4380 Enable chunk exclusion for space dimensions in UPDATE/DELETE
* #4384 Add schedule_interval to policies
* #4390 Faster lookup of chunks by point
* #4393 Support intervals with day component when constifying now()
* #4397 Support intervals with month component when constifying now()
* #4405 Support ON CONFLICT ON CONSTRAINT for hypertables
* #4412 Add telemetry about replication
* #4415 Drop remote data when detaching data node
* #4416 Handle TRUNCATE TABLE on chunks
* #4425 Add parameter check_config to alter_job
* #4430 Create index on Continuous Aggregates
* #4439 Allow ORDER BY on continuous aggregates
* #4443 Add stateful partition mappings
* #4484 Use non-blocking data node connections for COPY
* #4495 Support add_dimension() with existing data
* #4502 Add chunks to baserel cache on chunk exclusion
* #4545 Add hypertable distributed argument and defaults
* #4552 Migrate Continuous Aggregates to the new format
* #4556 Add runtime exclusion for hypertables
* #4561 Change get_git_commit to return full commit hash
* #4563 1 step CAgg policy management
* #4641 Allow bucketing by month, year, century in time_bucket and time_bucket_gapfill
* #4642 Add timezone support to time_bucket

**Bugfixes**
* #4359 Create composite index on segmentby columns
* #4374 Remove constified now() constraints from plan
* #4416 Handle TRUNCATE TABLE on chunks
* #4478 Synchronize chunk cache sizes
* #4486 Adding boolean column with default value doesn't work on compressed table
* #4512 Fix unaligned pointer access
* #4519 Throw better error message on incompatible row fetcher settings
* #4549 Fix dump_meta_data for windows
* #4553 Fix timescaledb_post_restore GUC handling
* #4573 Load TSL library on compressed_data_out call
* #4575 Fix use of `get_partition_hash` and `get_partition_for_key` inside an IMMUTABLE function
* #4577 Fix segfaults in compression code with corrupt data
* #4580 Handle default privileges on CAggs properly
* #4582 Fix assertion in GRANT .. ON ALL TABLES IN SCHEMA
* #4583 Fix partitioning functions
* #4589 Fix rename for distributed hypertable
* #4601 Reset compression sequence when group resets
* #4611 Fix a potential OOM when loading large data sets into a hypertable
* #4624 Fix heap buffer overflow
* #4627 Fix telemetry initialization
* #4631 Ensure TSL library is loaded on database upgrades
* #4646 Fix time_bucket_ng origin handling
* #4647 Fix the error "SubPlan found with no parent plan" that occurred if using joins in RETURNING clause.

**Thanks**
* @AlmiS for reporting error on `get_partition_hash` executed inside an IMMUTABLE function
* @Creatation for reporting an issue with renaming hypertables
* @janko for reporting an issue when adding bool column with default value to compressed hypertable
* @jayadevanm for reporting error of TRUNCATE TABLE on compressed chunk
* @michaelkitson for reporting permission errors using default privileges on Continuous Aggregates
* @mwahlhuetter for reporting error in joins in RETURNING clause
* @ninjaltd and @mrksngl for reporting a potential OOM when loading large data sets into a hypertable
* @PBudmark for reporting an issue with dump_meta_data.sql on Windows
* @ssmoss for reporting an issue with time_bucket_ng origin handling
svenklemm added a commit that referenced this pull request Aug 31, 2022
@svenklemm
Release 2.8.0
40b052e 
This release adds major new features since the 2.7.2 release.
We deem it moderate priority for upgrading.

This release includes these noteworthy features:

* time_bucket now supports bucketing by month, year and timezone
* Improve performance of bulk SELECT and COPY for distributed hypertables
* 1 step CAgg policy management
* Migrate Continuous Aggregates to the new format

**Features**
* #4188 Use COPY protocol in row-by-row fetcher
* #4307 Mark partialize_agg as parallel safe
* #4380 Enable chunk exclusion for space dimensions in UPDATE/DELETE
* #4384 Add schedule_interval to policies
* #4390 Faster lookup of chunks by point
* #4393 Support intervals with day component when constifying now()
* #4397 Support intervals with month component when constifying now()
* #4405 Support ON CONFLICT ON CONSTRAINT for hypertables
* #4412 Add telemetry about replication
* #4415 Drop remote data when detaching data node
* #4416 Handle TRUNCATE TABLE on chunks
* #4425 Add parameter check_config to alter_job
* #4430 Create index on Continuous Aggregates
* #4439 Allow ORDER BY on continuous aggregates
* #4443 Add stateful partition mappings
* #4484 Use non-blocking data node connections for COPY
* #4495 Support add_dimension() with existing data
* #4502 Add chunks to baserel cache on chunk exclusion
* #4545 Add hypertable distributed argument and defaults
* #4552 Migrate Continuous Aggregates to the new format
* #4556 Add runtime exclusion for hypertables
* #4561 Change get_git_commit to return full commit hash
* #4563 1 step CAgg policy management
* #4641 Allow bucketing by month, year, century in time_bucket and time_bucket_gapfill
* #4642 Add timezone support to time_bucket

**Bugfixes**
* #4359 Create composite index on segmentby columns
* #4374 Remove constified now() constraints from plan
* #4416 Handle TRUNCATE TABLE on chunks
* #4478 Synchronize chunk cache sizes
* #4486 Adding boolean column with default value doesn't work on compressed table
* #4512 Fix unaligned pointer access
* #4519 Throw better error message on incompatible row fetcher settings
* #4549 Fix dump_meta_data for windows
* #4553 Fix timescaledb_post_restore GUC handling
* #4573 Load TSL library on compressed_data_out call
* #4575 Fix use of `get_partition_hash` and `get_partition_for_key` inside an IMMUTABLE function
* #4577 Fix segfaults in compression code with corrupt data
* #4580 Handle default privileges on CAggs properly
* #4582 Fix assertion in GRANT .. ON ALL TABLES IN SCHEMA
* #4583 Fix partitioning functions
* #4589 Fix rename for distributed hypertable
* #4601 Reset compression sequence when group resets
* #4611 Fix a potential OOM when loading large data sets into a hypertable
* #4624 Fix heap buffer overflow
* #4627 Fix telemetry initialization
* #4631 Ensure TSL library is loaded on database upgrades
* #4646 Fix time_bucket_ng origin handling
* #4647 Fix the error "SubPlan found with no parent plan" that occurred if using joins in RETURNING clause.

**Thanks**
* @AlmiS for reporting error on `get_partition_hash` executed inside an IMMUTABLE function
* @Creatation for reporting an issue with renaming hypertables
* @janko for reporting an issue when adding bool column with default value to compressed hypertable
* @jayadevanm for reporting error of TRUNCATE TABLE on compressed chunk
* @michaelkitson for reporting permission errors using default privileges on Continuous Aggregates
* @mwahlhuetter for reporting error in joins in RETURNING clause
* @ninjaltd and @mrksngl for reporting a potential OOM when loading large data sets into a hypertable
* @PBudmark for reporting an issue with dump_meta_data.sql on Windows
* @ssmoss for reporting an issue with time_bucket_ng origin handling
svenklemm added a commit that referenced this pull request Aug 31, 2022
@svenklemm
Release 2.8.0
2410bdf 
This release adds major new features since the 2.7.2 release.
We deem it moderate priority for upgrading.

This release includes these noteworthy features:

* time_bucket now supports bucketing by month, year and timezone
* Improve performance of bulk SELECT and COPY for distributed hypertables
* 1 step CAgg policy management
* Migrate Continuous Aggregates to the new format

**Features**
* #4188 Use COPY protocol in row-by-row fetcher
* #4307 Mark partialize_agg as parallel safe
* #4380 Enable chunk exclusion for space dimensions in UPDATE/DELETE
* #4384 Add schedule_interval to policies
* #4390 Faster lookup of chunks by point
* #4393 Support intervals with day component when constifying now()
* #4397 Support intervals with month component when constifying now()
* #4405 Support ON CONFLICT ON CONSTRAINT for hypertables
* #4412 Add telemetry about replication
* #4415 Drop remote data when detaching data node
* #4416 Handle TRUNCATE TABLE on chunks
* #4425 Add parameter check_config to alter_job
* #4430 Create index on Continuous Aggregates
* #4439 Allow ORDER BY on continuous aggregates
* #4443 Add stateful partition mappings
* #4484 Use non-blocking data node connections for COPY
* #4495 Support add_dimension() with existing data
* #4502 Add chunks to baserel cache on chunk exclusion
* #4545 Add hypertable distributed argument and defaults
* #4552 Migrate Continuous Aggregates to the new format
* #4556 Add runtime exclusion for hypertables
* #4561 Change get_git_commit to return full commit hash
* #4563 1 step CAgg policy management
* #4641 Allow bucketing by month, year, century in time_bucket and time_bucket_gapfill
* #4642 Add timezone support to time_bucket

**Bugfixes**
* #4359 Create composite index on segmentby columns
* #4374 Remove constified now() constraints from plan
* #4416 Handle TRUNCATE TABLE on chunks
* #4478 Synchronize chunk cache sizes
* #4486 Adding boolean column with default value doesn't work on compressed table
* #4512 Fix unaligned pointer access
* #4519 Throw better error message on incompatible row fetcher settings
* #4549 Fix dump_meta_data for windows
* #4553 Fix timescaledb_post_restore GUC handling
* #4573 Load TSL library on compressed_data_out call
* #4575 Fix use of `get_partition_hash` and `get_partition_for_key` inside an IMMUTABLE function
* #4577 Fix segfaults in compression code with corrupt data
* #4580 Handle default privileges on CAggs properly
* #4582 Fix assertion in GRANT .. ON ALL TABLES IN SCHEMA
* #4583 Fix partitioning functions
* #4589 Fix rename for distributed hypertable
* #4601 Reset compression sequence when group resets
* #4611 Fix a potential OOM when loading large data sets into a hypertable
* #4624 Fix heap buffer overflow
* #4627 Fix telemetry initialization
* #4631 Ensure TSL library is loaded on database upgrades
* #4646 Fix time_bucket_ng origin handling
* #4647 Fix the error "SubPlan found with no parent plan" that occurred if using joins in RETURNING clause.

**Thanks**
* @AlmiS for reporting error on `get_partition_hash` executed inside an IMMUTABLE function
* @Creatation for reporting an issue with renaming hypertables
* @janko for reporting an issue when adding bool column with default value to compressed hypertable
* @jayadevanm for reporting error of TRUNCATE TABLE on compressed chunk
* @michaelkitson for reporting permission errors using default privileges on Continuous Aggregates
* @mwahlhuetter for reporting error in joins in RETURNING clause
* @ninjaltd and @mrksngl for reporting a potential OOM when loading large data sets into a hypertable
* @PBudmark for reporting an issue with dump_meta_data.sql on Windows
* @ssmoss for reporting an issue with time_bucket_ng origin handling
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akuzm akuzm akuzm approved these changes

@konskov konskov konskov approved these changes

@fabriziomello fabriziomello Awaiting requested review from fabriziomello

@gayyappan gayyappan Awaiting requested review from gayyappan

@jnidzwetzki jnidzwetzki Awaiting requested review from jnidzwetzki

@mfundul mfundul Awaiting requested review from mfundul

@erimatnor erimatnor Awaiting requested review from erimatnor

Assignees

@svenklemm svenklemm

Labels
None yet
Projects
None yet
Milestone
TimescaleDB 2.8
Development

Successfully merging this pull request may close these issues.

Support for month, year and time zones in time_bucket
4 participants
@svenklemm @erimatnor @akuzm @konskov