Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement]: Disallow COMMIT in user-defined check procedure #4703

Closed
konskov opened this issue Sep 14, 2022 · 0 comments · Fixed by #4711
Closed

[Enhancement]: Disallow COMMIT in user-defined check procedure #4703

konskov opened this issue Sep 14, 2022 · 0 comments · Fixed by #4711
Assignees
@konskov
Labels
enhancement An enhancement to an existing feature for functionality

Comments

@konskov
Copy link
Contributor

konskov commented Sep 14, 2022

What type of enhancement is this?

User experience

What subsystems and features will be improved?

User-Defined Action (UDA)

What does the enhancement do?

The objective would be to prevent crashes like the one mentioned in #4691

Implementation challenges

No response
@konskov konskov added the enhancement An enhancement to an existing feature for functionality label Sep 14, 2022
@konskov konskov changed the title [Enhancement]: Disallow COMMIT in user-defined check function [Enhancement]: Disallow COMMIT in user-defined check procedure Sep 14, 2022
@konskov konskov self-assigned this Sep 14, 2022
konskov added a commit to konskov/timescaledb that referenced this issue Sep 15, 2022
@konskov
Remove support for procedures as custom checks
ad486cd 
Fixes timescale#4703
@konskov konskov mentioned this issue Sep 15, 2022
Merged
konskov added a commit to konskov/timescaledb that referenced this issue Sep 15, 2022
@konskov
Remove support for procedures as custom checks
de6d0db 
Procedures doing their own transaction handling could lead to errors
or even crashes.

Fixes timescale#4703
konskov added a commit to konskov/timescaledb that referenced this issue Sep 16, 2022
@konskov
Remove support for procedures as custom checks
e4c2e32 
Procedures doing their own transaction handling could lead to errors
or even crashes.

Fixes timescale#4703
konskov added a commit to konskov/timescaledb that referenced this issue Sep 16, 2022
@konskov
Remove support for procedures as custom checks
6826ae7 
Procedures doing their own transaction handling could lead to errors
or even crashes.

Fixes timescale#4703
konskov added a commit to konskov/timescaledb that referenced this issue Sep 16, 2022
@konskov
Remove support for procedures as custom checks
c9bcf0a 
Procedures doing their own transaction handling could lead to errors
or even crashes.

Fixes timescale#4703
konskov added a commit to konskov/timescaledb that referenced this issue Sep 18, 2022
@konskov
Remove support for procedures as custom checks
5144e97 
Procedures doing their own transaction handling could lead to errors
or even crashes.

Fixes timescale#4703
konskov added a commit that referenced this issue Sep 19, 2022
@konskov
Remove support for procedures as custom checks
97a603f 
Procedures doing their own transaction handling could lead to errors
or even crashes.

Fixes #4703
jnidzwetzki pushed a commit to jnidzwetzki/timescaledb that referenced this issue Sep 29, 2022
@konskov @jnidzwetzki
Remove support for procedures as custom checks
b5cfddb 
Procedures doing their own transaction handling could lead to errors
or even crashes.

Fixes timescale#4703
jnidzwetzki pushed a commit to jnidzwetzki/timescaledb that referenced this issue Sep 30, 2022
@konskov @jnidzwetzki
Remove support for procedures as custom checks
81197f2 
Procedures doing their own transaction handling could lead to errors
or even crashes.

Fixes timescale#4703
jnidzwetzki pushed a commit to jnidzwetzki/timescaledb that referenced this issue Sep 30, 2022
@konskov @jnidzwetzki
Remove support for procedures as custom checks
d971ad3 
Procedures doing their own transaction handling could lead to errors
or even crashes.

Fixes timescale#4703
jnidzwetzki pushed a commit to jnidzwetzki/timescaledb that referenced this issue Sep 30, 2022
@konskov @jnidzwetzki
Remove support for procedures as custom checks
6abab59 
Procedures doing their own transaction handling could lead to errors
or even crashes.

Fixes timescale#4703
jnidzwetzki pushed a commit to jnidzwetzki/timescaledb that referenced this issue Oct 4, 2022
@konskov @jnidzwetzki
Remove support for procedures as custom checks
f4e58be 
Procedures doing their own transaction handling could lead to errors
or even crashes.

Fixes timescale#4703
jnidzwetzki pushed a commit that referenced this issue Oct 6, 2022
@konskov @jnidzwetzki
Remove support for procedures as custom checks
e40dda7 
Procedures doing their own transaction handling could lead to errors
or even crashes.

Fixes #4703
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@konskov konskov

Labels
enhancement An enhancement to an existing feature for functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove support for procedures as custom checks konskov/timescaledb
1 participant
@konskov