Fix ChunkAppend with prepared statements #1369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svenklemm
force-pushed
the
chunk_append_prepared_statements
branch
from
7f73f48
to
0b0594b
Compare
Codecov Report
@@ Coverage Diff @@
## master #1369 +/- ##
===========================================
- Coverage 92.05% 80.73% -11.32%
===========================================
Files 114 112 -2
Lines 14756 16104 +1348
===========================================
- Hits 13584 13002 -582
- Misses 1172 3102 +1930
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #1369 +/- ##
==========================================
- Coverage 92.05% 80.76% -11.3%
==========================================
Files 114 114
Lines 14758 16437 +1679
==========================================
- Hits 13586 13275 -311
- Misses 1172 3162 +1990
Continue to review full report at Codecov.
|
ChunkAppend replaced the list of child plans on the plan node with a local copy which corrupted the child plans when the plan was turned into a generic plan.
svenklemm
force-pushed
the
chunk_append_prepared_statements
branch
from
0b0594b
to
39a57a7
Compare
cevian
approved these changes
Jul 24, 2019
Merged
svenklemm
added a commit
to svenklemm/timescaledb
that referenced
this pull request
Jul 31, 2019
This maintenance release contains bugfixes since the 1.4.0 release. We deem it medium priority for upgrading. In particular the fixes contained in this maintenance release address 2 potential segfaults and no other security vulnerabilities. The bugfixes are related to queries with prepared statements, PL/pgSQL functions and interoperability with other extensions. More details below. **Bugfixes** * timescale#1362 Fix ConstraintAwareAppend subquery exclusion * timescale#1363 Mark drop_chunks as VOLATILE and not PARALLEL SAFE * timescale#1369 Fix ChunkAppend with prepared statements * timescale#1373 Only allow PARAM_EXTERN as time_bucket_gapfill arguments * timescale#1380 Handle Result nodes gracefully in ChunkAppend **Thanks** * @overhacked for reporting an issue with drop_chunks and parallel queries * @fvannee for reporting an issue with ConstraintAwareAppend and subqueries * @rrb3942 for reporting a segfault with ChunkAppend and prepared statements * @mchesser for reporting a segfault with time_bucket_gapfill and subqueries * @lolizeppelin for reporting and helping debug an issue with ChunkAppend and Result nodes
svenklemm
added a commit
that referenced
this pull request
Jul 31, 2019
This maintenance release contains bugfixes since the 1.4.0 release. We deem it medium priority for upgrading. In particular the fixes contained in this maintenance release address 2 potential segfaults and no other security vulnerabilities. The bugfixes are related to queries with prepared statements, PL/pgSQL functions and interoperability with other extensions. More details below. **Bugfixes** * #1362 Fix ConstraintAwareAppend subquery exclusion * #1363 Mark drop_chunks as VOLATILE and not PARALLEL SAFE * #1369 Fix ChunkAppend with prepared statements * #1373 Only allow PARAM_EXTERN as time_bucket_gapfill arguments * #1380 Handle Result nodes gracefully in ChunkAppend **Thanks** * @overhacked for reporting an issue with drop_chunks and parallel queries * @fvannee for reporting an issue with ConstraintAwareAppend and subqueries * @rrb3942 for reporting a segfault with ChunkAppend and prepared statements * @mchesser for reporting a segfault with time_bucket_gapfill and subqueries * @lolizeppelin for reporting and helping debug an issue with ChunkAppend and Result nodes
svenklemm
added a commit
that referenced
this pull request
Jul 31, 2019
This maintenance release contains bugfixes since the 1.4.0 release. We deem it medium priority for upgrading. In particular the fixes contained in this maintenance release address 2 potential segfaults and no other security vulnerabilities. The bugfixes are related to queries with prepared statements, PL/pgSQL functions and interoperability with other extensions. More details below. **Bugfixes** * #1362 Fix ConstraintAwareAppend subquery exclusion * #1363 Mark drop_chunks as VOLATILE and not PARALLEL SAFE * #1369 Fix ChunkAppend with prepared statements * #1373 Only allow PARAM_EXTERN as time_bucket_gapfill arguments * #1380 Handle Result nodes gracefully in ChunkAppend **Thanks** * @overhacked for reporting an issue with drop_chunks and parallel queries * @fvannee for reporting an issue with ConstraintAwareAppend and subqueries * @rrb3942 for reporting a segfault with ChunkAppend and prepared statements * @mchesser for reporting a segfault with time_bucket_gapfill and subqueries * @lolizeppelin for reporting and helping debug an issue with ChunkAppend and Result nodes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ChunkAppend replaced the list of child plans on the plan node with
a local copy which corrupted the child plans when the plan was
turned into a generic plan.
Fixes #1368