Improve continuous agg user messages #1592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JLockerman
approved these changes
Dec 18, 2019
gayyappan
reviewed
Dec 19, 2019
| @@ -421,11 +421,11 @@ get_materialization_end_point_for_table(int32 raw_hypertable_id, int32 materiali | |||
| if (verbose) | |||
| elog(INFO, | |||
| "new materialization range not found for %s.%s (time column %s): " | |||
| "not enough new data past completion threshold (" INT64_FORMAT ")", | |||
| "not enough new data past completion threshold as of %s", | |||
There was a problem hiding this comment.
am confused by this message.
I expect as "as of %s" to show now() . But we use "as of" with reference to the different thresholds. Rewording to indicate what is the displayed value will help.
gayyappan
reviewed
Dec 19, 2019
| @@ -396,11 +396,11 @@ get_materialization_end_point_for_table(int32 raw_hypertable_id, int32 materiali | |||
| if (verbose) | |||
| elog(INFO, | |||
| "new materialization range not found for %s.%s (time column %s): not enough data " | |||
| "in table (" INT64_FORMAT ")", | |||
| "past minimum time value as of %s", | |||
There was a problem hiding this comment.
this should be reworded. suggest we use some terms from the docs for the messages. suggestion "past materialization threshold as of %s".
There was a problem hiding this comment.
This is actually the correct message since it deals with underflow not any of the thresholds
There was a problem hiding this comment.
How about rewording it as: " new materialization range not found ....: not enough data that satisfies refresh lag criterion as of ..."? ( minimum time value does not make much sense to end user?)
gayyappan
reviewed
Dec 19, 2019
cevian
force-pushed
the
cont_agg_better_msgs
branch
from
ea35e26
to
c9e7139
Compare
Codecov Report
@@ Coverage Diff @@
## master #1592 +/- ##
==========================================
+ Coverage 89.52% 91.91% +2.38%
==========================================
Files 144 142 -2
Lines 21593 20997 -596
==========================================
- Hits 19332 19299 -33
+ Misses 2261 1698 -563
Continue to review full report at Codecov.
|
gayyappan
approved these changes
Dec 31, 2019
cevian
force-pushed
the
cont_agg_better_msgs
branch
3 times, most recently
from
7ef57af
to
9c612df
Compare
Switch from using internal timestamps to more user-friendly timestamps in our log messages and clean up some messages.
cevian
force-pushed
the
cont_agg_better_msgs
branch
from
9c612df
to
d2c2078
Compare
svenklemm
added a commit
to svenklemm/timescaledb
that referenced
this pull request
Jan 15, 2020
This release adds major new features and bugfixes since the 1.5.1 release. We deem it moderate priority for upgrading. The major new feature in this release allows users to keep the aggregated data in a continuous aggregate while dropping the raw data with drop_chunks. This allows users to save storage by keeping only the aggregates. The semantics of the refresh_lag parameter for continuous aggregates has been changed to be relative to the current timestamp instead of the maximum value in the table. This change requires that an integer_now func be set on hypertables with integer-based time columns to use continuous aggregates on this table. We added a timescaledb.ignore_invalidation_older_than parameter for continuous aggregatess. This parameter accept a time-interval (e.g. 1 month). if set, it limits the amount of time for which to process invalidation. Thus, if timescaledb.ignore_invalidation_older_than = '1 month', then any modifications for data older than 1 month from the current timestamp at modification time may not cause continuous aggregate to be updated. This limits the amount of work that a backfill can trigger. By default, all invalidations are processed. **Major Features** * timescale#1589 Allow drop_chunks while keeping continuous aggregates **Minor Features** * timescale#1568 Add ignore_invalidation_older_than option to continuous aggs * timescale#1575 Reorder group-by clause for continuous aggregates * timescale#1592 Improve continuous agg user messages **Bugfixes** * timescale#1565 Fix partial select query for continuous aggregate * timescale#1591 Fix locf treat_null_as_missing option * timescale#1594 Fix error in compression constraint check * timescale#1603 Add join info to compressed chunk * timescale#1606 Fix constify params during runtime exclusion * timescale#1607 Delete compression policy when drop hypertable * timescale#1608 Add jobs to timescaledb_information.policy_stats * timescale#1609 Fix bug with parent table in decompression **Thanks** * @optijon for reporting an issue with locf treat_null_as_missing option * @acarrera42 for reporting an issue with constify params during runtime exclusion * @ChristopherZellermann for reporting an issue with the compression constraint check * @SimonDelamare for reporting an issue with joining hypertables with compression
svenklemm
added a commit
to svenklemm/timescaledb
that referenced
this pull request
Jan 15, 2020
This release adds major new features and bugfixes since the 1.5.1 release. We deem it moderate priority for upgrading. The major new feature in this release allows users to keep the aggregated data in a continuous aggregate while dropping the raw data with drop_chunks. This allows users to save storage by keeping only the aggregates. The semantics of the refresh_lag parameter for continuous aggregates has been changed to be relative to the current timestamp instead of the maximum value in the table. This change requires that an integer_now func be set on hypertables with integer-based time columns to use continuous aggregates on this table. We added a timescaledb.ignore_invalidation_older_than parameter for continuous aggregatess. This parameter accept a time-interval (e.g. 1 month). if set, it limits the amount of time for which to process invalidation. Thus, if timescaledb.ignore_invalidation_older_than = '1 month', then any modifications for data older than 1 month from the current timestamp at modification time may not cause continuous aggregate to be updated. This limits the amount of work that a backfill can trigger. By default, all invalidations are processed. **Major Features** * timescale#1589 Allow drop_chunks while keeping continuous aggregates **Minor Features** * timescale#1568 Add ignore_invalidation_older_than option to continuous aggs * timescale#1575 Reorder group-by clause for continuous aggregates * timescale#1592 Improve continuous agg user messages **Bugfixes** * timescale#1565 Fix partial select query for continuous aggregate * timescale#1591 Fix locf treat_null_as_missing option * timescale#1594 Fix error in compression constraint check * timescale#1603 Add join info to compressed chunk * timescale#1606 Fix constify params during runtime exclusion * timescale#1607 Delete compression policy when drop hypertable * timescale#1608 Add jobs to timescaledb_information.policy_stats * timescale#1609 Fix bug with parent table in decompression * timescale#1624 Fix drop_chunks for ApacheOnly * timescale#1632 Check for NULL before dereferencing variable **Thanks** * @optijon for reporting an issue with locf treat_null_as_missing option * @acarrera42 for reporting an issue with constify params during runtime exclusion * @ChristopherZellermann for reporting an issue with the compression constraint check * @SimonDelamare for reporting an issue with joining hypertables with compression
svenklemm
added a commit
that referenced
this pull request
Jan 15, 2020
This release adds major new features and bugfixes since the 1.5.1 release. We deem it moderate priority for upgrading. The major new feature in this release allows users to keep the aggregated data in a continuous aggregate while dropping the raw data with drop_chunks. This allows users to save storage by keeping only the aggregates. The semantics of the refresh_lag parameter for continuous aggregates has been changed to be relative to the current timestamp instead of the maximum value in the table. This change requires that an integer_now func be set on hypertables with integer-based time columns to use continuous aggregates on this table. We added a timescaledb.ignore_invalidation_older_than parameter for continuous aggregatess. This parameter accept a time-interval (e.g. 1 month). if set, it limits the amount of time for which to process invalidation. Thus, if timescaledb.ignore_invalidation_older_than = '1 month', then any modifications for data older than 1 month from the current timestamp at modification time may not cause continuous aggregate to be updated. This limits the amount of work that a backfill can trigger. By default, all invalidations are processed. **Major Features** * #1589 Allow drop_chunks while keeping continuous aggregates **Minor Features** * #1568 Add ignore_invalidation_older_than option to continuous aggs * #1575 Reorder group-by clause for continuous aggregates * #1592 Improve continuous agg user messages **Bugfixes** * #1565 Fix partial select query for continuous aggregate * #1591 Fix locf treat_null_as_missing option * #1594 Fix error in compression constraint check * #1603 Add join info to compressed chunk * #1606 Fix constify params during runtime exclusion * #1607 Delete compression policy when drop hypertable * #1608 Add jobs to timescaledb_information.policy_stats * #1609 Fix bug with parent table in decompression * #1624 Fix drop_chunks for ApacheOnly * #1632 Check for NULL before dereferencing variable **Thanks** * @optijon for reporting an issue with locf treat_null_as_missing option * @acarrera42 for reporting an issue with constify params during runtime exclusion * @ChristopherZellermann for reporting an issue with the compression constraint check * @SimonDelamare for reporting an issue with joining hypertables with compression
svenklemm
added a commit
that referenced
this pull request
Jan 15, 2020
This release adds major new features and bugfixes since the 1.5.1 release. We deem it moderate priority for upgrading. The major new feature in this release allows users to keep the aggregated data in a continuous aggregate while dropping the raw data with drop_chunks. This allows users to save storage by keeping only the aggregates. The semantics of the refresh_lag parameter for continuous aggregates has been changed to be relative to the current timestamp instead of the maximum value in the table. This change requires that an integer_now func be set on hypertables with integer-based time columns to use continuous aggregates on this table. We added a timescaledb.ignore_invalidation_older_than parameter for continuous aggregatess. This parameter accept a time-interval (e.g. 1 month). if set, it limits the amount of time for which to process invalidation. Thus, if timescaledb.ignore_invalidation_older_than = '1 month', then any modifications for data older than 1 month from the current timestamp at modification time may not cause continuous aggregate to be updated. This limits the amount of work that a backfill can trigger. By default, all invalidations are processed. **Major Features** * #1589 Allow drop_chunks while keeping continuous aggregates **Minor Features** * #1568 Add ignore_invalidation_older_than option to continuous aggs * #1575 Reorder group-by clause for continuous aggregates * #1592 Improve continuous agg user messages **Bugfixes** * #1565 Fix partial select query for continuous aggregate * #1591 Fix locf treat_null_as_missing option * #1594 Fix error in compression constraint check * #1603 Add join info to compressed chunk * #1606 Fix constify params during runtime exclusion * #1607 Delete compression policy when drop hypertable * #1608 Add jobs to timescaledb_information.policy_stats * #1609 Fix bug with parent table in decompression * #1624 Fix drop_chunks for ApacheOnly * #1632 Check for NULL before dereferencing variable **Thanks** * @optijon for reporting an issue with locf treat_null_as_missing option * @acarrera42 for reporting an issue with constify params during runtime exclusion * @ChristopherZellermann for reporting an issue with the compression constraint check * @SimonDelamare for reporting an issue with joining hypertables with compression
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch from using internal timestamps to more user-friendly
timestamps in our log messages and clean up some messages.