-
Notifications
You must be signed in to change notification settings - Fork 852
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable tests by default if tools are not found #3468
Conversation
354e2e8
to
27ee8a7
Compare
Codecov Report
@@ Coverage Diff @@
## master #3468 +/- ##
===========================================
- Coverage 90.73% 34.92% -55.82%
===========================================
Files 212 212
Lines 36258 36258
===========================================
- Hits 32900 12664 -20236
- Misses 3358 23594 +20236
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make format is entirely optional for the build process. not sure why we would need an option to enable it since it's sufficient and much more user friendly to check at execution time for the availabilty. this is also much more friendly to packagers.
If However, that raises the issue why we do not do the same when |
b14ebbc
to
817afcf
Compare
The pull request is updated to by default disable tests if they are not found. It also moves some of the checks for programs to the topmost |
If tools like `pg_regress` or `pg_isolation_regress` are not found, an error is generated telling you that you need to disable the tests explicitly using `REGRESS_CHECKS`. This is an inconvenience for the user since in most cases you just want to build the system with what you have. This commit changes that by automatically disabling regression tests, isolation tests, TAP tests, and formatting targets when tools cannot be found, which means that users do not normally have to disable tests explicitly. A notice is still printed that the targets are not added. In addition, the commit adds an option `REQUIRE_ALL_TESTS` for the rare case when you want to make sure that all tests are indeed executed (for example, in CI runs), which by default is off.
817afcf
to
d5a09de
Compare
This release contains bug fixes since the 2.4.0 release. We deem it high priority to upgrade since it is needed to support PostgreSQL 12.8 and 13.4. **Bugfixes** * timescale#3430 Fix havingqual processing for continuous aggregates * timescale#3468 Disable tests by default if tools are not found * timescale#3468 Fix crash while tracking alter table commands * timescale#3494 Improve error message when adding data nodes * timescale#3498 Fix continuous agg bgw job failure for PG 12.8 and 13.4 **Thanks** * @brianbenns for reporting a segfault with continuous aggregates
This release contains bug fixes since the 2.4.0 release. We deem it high priority to upgrade since it is needed to support PostgreSQL 12.8 and 13.4. **Bugfixes** * timescale#3430 Fix havingqual processing for continuous aggregates * timescale#3468 Disable tests by default if tools are not found * timescale#3468 Fix crash while tracking alter table commands * timescale#3494 Improve error message when adding data nodes * timescale#3498 Fix continuous agg bgw job failure for PG 12.8 and 13.4 **Thanks** * @brianbenns for reporting a segfault with continuous aggregates
This release contains bug fixes since the 2.4.0 release. We deem it high priority to upgrade since it is needed to support PostgreSQL 12.8 and 13.4. **Bugfixes** * timescale#3430 Fix havingqual processing for continuous aggregates * timescale#3468 Disable tests by default if tools are not found * timescale#3468 Fix crash while tracking alter table commands * timescale#3494 Improve error message when adding data nodes * timescale#3498 Fix continuous agg bgw job failure for PG 12.8 and 13.4 **Thanks** * @brianbenns for reporting a segfault with continuous aggregates
This release contains bug fixes since the 2.4.0 release. We deem it high priority to upgrade since it is needed to support PostgreSQL 12.8 and 13.4. **Bugfixes** * timescale#3430 Fix havingqual processing for continuous aggregates * timescale#3468 Disable tests by default if tools are not found * timescale#3468 Fix crash while tracking alter table commands * timescale#3494 Improve error message when adding data nodes * timescale#3498 Fix continuous agg bgw job failure for PG 12.8 and 13.4 **Thanks** * @brianbenns for reporting a segfault with continuous aggregates
This release contains bug fixes since the 2.4.0 release. We deem it high priority to upgrade since it is needed to support PostgreSQL 12.8 and 13.4. **Bugfixes** * timescale#3430 Fix havingqual processing for continuous aggregates * timescale#3468 Disable tests by default if tools are not found * timescale#3468 Fix crash while tracking alter table commands * timescale#3494 Improve error message when adding data nodes * timescale#3498 Fix continuous agg bgw job failure for PG 12.8 and 13.4 **Thanks** * @brianbenns for reporting a segfault with continuous aggregates
This release contains bug fixes since the 2.4.0 release. We deem it high priority to upgrade since it is needed to support PostgreSQL 12.8 and 13.4. **Bugfixes** * timescale#3430 Fix havingqual processing for continuous aggregates * timescale#3468 Disable tests by default if tools are not found * timescale#3468 Fix crash while tracking alter table commands * timescale#3494 Improve error message when adding data nodes * timescale#3498 Fix continuous agg bgw job failure for PG 12.8 and 13.4 **Thanks** * @brianbenns for reporting a segfault with continuous aggregates
This release contains bug fixes since the 2.4.0 release. We deem it high priority to upgrade since it is needed to support PostgreSQL 12.8 and 13.4. **Bugfixes** * timescale#3430 Fix havingqual processing for continuous aggregates * timescale#3468 Disable tests by default if tools are not found * timescale#3468 Fix crash while tracking alter table commands * timescale#3494 Improve error message when adding data nodes * timescale#3498 Fix continuous agg bgw job failure for PG 12.8 and 13.4 **Thanks** * @brianbenns for reporting a segfault with continuous aggregates
This release contains bug fixes since the 2.4.0 release. We deem it high priority to upgrade since it is needed to support PostgreSQL 12.8 and 13.4. **Bugfixes** * timescale#3430 Fix havingqual processing for continuous aggregates * timescale#3468 Disable tests by default if tools are not found * timescale#3468 Fix crash while tracking alter table commands * timescale#3494 Improve error message when adding data nodes * timescale#3498 Fix continuous agg bgw job failure for PG 12.8 and 13.4 **Thanks** * @brianbenns for reporting a segfault with continuous aggregates
This release contains bug fixes since the 2.4.0 release. We deem it high priority to upgrade since it is needed to support PostgreSQL 12.8 and 13.4. **Bugfixes** * timescale#3430 Fix havingqual processing for continuous aggregates * timescale#3468 Disable tests by default if tools are not found * timescale#3468 Fix crash while tracking alter table commands * timescale#3494 Improve error message when adding data nodes * timescale#3498 Fix continuous agg bgw job failure for PG 12.8 and 13.4 **Thanks** * @brianbenns for reporting a segfault with continuous aggregates
This release contains bug fixes since the 2.4.0 release. We deem it high priority to upgrade. The release fixes continous aggregate refresh for postgres 12.8 and 13.4, a crash with ALTER TABLE commands and a crash with continuous aggregates with HAVING clause. **Bugfixes** * timescale#3430 Fix havingqual processing for continuous aggregates * timescale#3468 Disable tests by default if tools are not found * timescale#3462 Fix crash while tracking alter table commands * timescale#3489 Fix continuous agg bgw job failure for PG 12.8 and 13.4 * timescale#3494 Improve error message when adding data nodes **Thanks** * @brianbenns for reporting a segfault with continuous aggregates * @brianbenns for reporting a segfault with continuous aggregates * @usego for reporting an issue with continuous aggregate refresh on PG 13.4
This release contains bug fixes since the 2.4.0 release. We deem it high priority to upgrade. The release fixes continous aggregate refresh for postgres 12.8 and 13.4, a crash with ALTER TABLE commands and a crash with continuous aggregates with HAVING clause. **Bugfixes** * #3430 Fix havingqual processing for continuous aggregates * #3468 Disable tests by default if tools are not found * #3462 Fix crash while tracking alter table commands * #3489 Fix continuous agg bgw job failure for PG 12.8 and 13.4 * #3494 Improve error message when adding data nodes **Thanks** * @brianbenns for reporting a segfault with continuous aggregates * @brianbenns for reporting a segfault with continuous aggregates * @usego for reporting an issue with continuous aggregate refresh on PG 13.4
This release contains bug fixes since the 2.4.0 release. We deem it high priority to upgrade. The release fixes continous aggregate refresh for postgres 12.8 and 13.4, a crash with ALTER TABLE commands and a crash with continuous aggregates with HAVING clause. **Bugfixes** * timescale#3430 Fix havingqual processing for continuous aggregates * timescale#3468 Disable tests by default if tools are not found * timescale#3462 Fix crash while tracking alter table commands * timescale#3489 Fix continuous agg bgw job failure for PG 12.8 and 13.4 * timescale#3494 Improve error message when adding data nodes **Thanks** * @brianbenns for reporting a segfault with continuous aggregates * @brianbenns for reporting a segfault with continuous aggregates * @usego for reporting an issue with continuous aggregate refresh on PG 13.4
This release contains bug fixes since the 2.4.0 release. We deem it high priority to upgrade. The release fixes continous aggregate refresh for postgres 12.8 and 13.4, a crash with ALTER TABLE commands and a crash with continuous aggregates with HAVING clause. **Bugfixes** * #3430 Fix havingqual processing for continuous aggregates * #3468 Disable tests by default if tools are not found * #3462 Fix crash while tracking alter table commands * #3489 Fix continuous agg bgw job failure for PG 12.8 and 13.4 * #3494 Improve error message when adding data nodes **Thanks** * @brianbenns for reporting a segfault with continuous aggregates * @usego for reporting an issue with continuous aggregate refresh on PG 13.4
This release contains bug fixes since the 2.4.0 release. We deem it high priority to upgrade. The release fixes continous aggregate refresh for postgres 12.8 and 13.4, a crash with ALTER TABLE commands and a crash with continuous aggregates with HAVING clause. **Bugfixes** * #3430 Fix havingqual processing for continuous aggregates * #3468 Disable tests by default if tools are not found * #3462 Fix crash while tracking alter table commands * #3489 Fix continuous agg bgw job failure for PG 12.8 and 13.4 * #3494 Improve error message when adding data nodes **Thanks** * @brianbenns for reporting a segfault with continuous aggregates * @brianbenns for reporting a segfault with continuous aggregates * @usego for reporting an issue with continuous aggregate refresh on PG 13.4
If tools like
pg_regress
orpg_isolation_regress
are not found, anerror is generated telling you that you need to disable the tests
explicitly using
REGRESS_CHECKS
. This is an inconvenience for theuser since in most cases you just want to build the system with what
you have.
This commit changes that by automatically disabling regression tests,
isolation tests, TAP tests, and formatting targets when tools cannot be
found, which means that users do not normally have to disable tests
explicitly. A notice is still printed that the targets are not added.
In addition, the commit adds an option
REQUIRE_ALL_TESTS
for the rarecase when you want to make sure that all tests are indeed executed (for
example, in CI runs), which by default is off.