Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix continuous agg refresh procedure failure with 12.8 #3489

Merged
merged 1 commit into from
Aug 17, 2021
Merged

Fix continuous agg refresh procedure failure with 12.8 #3489

merged 1 commit into from
Aug 17, 2021

Conversation

gayyappan
Copy link
Contributor

No description provided.

@gayyappan gayyappan force-pushed the bugfix_2 branch 3 times, most recently from 8fd3c18 to d757641 Compare August 16, 2021 21:24
@codecov
Copy link

codecov bot commented Aug 16, 2021 •
edited
Loading

Codecov Report

Merging #3489 (9f7cc70) into master (bff87a8) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3489      +/-   ##
==========================================
- Coverage   90.73%   90.70%   -0.04%     
==========================================
  Files         212      212              
  Lines       36258    36260       +2     
==========================================
- Hits        32900    32889      -11     
- Misses       3358     3371      +13
Impacted Files Coverage Δ
tsl/src/continuous_aggs/refresh.c 97.57% <100.00%> (+0.02%) ⬆️
src/loader/bgw_message_queue.c 85.52% <0.00%> (-2.64%) ⬇️
src/loader/bgw_launcher.c 89.47% <0.00%> (-2.48%) ⬇️
tsl/src/nodes/data_node_dispatch.c 97.08% <0.00%> (-0.25%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bff87a8...9f7cc70. Read the comment docs.

@gayyappan
Fix continuous agg bgw job failure for PG 12.8 and 13.4
9f7cc70 
Procedures that have multiple transcations have to manage their
snapshots if they do not use SPI internally for SQL commands
and are invoked via C code.
See PG commit 84f5c2908dad81e8622b0406beea580e40bb03ac
for details.

Fixes timescale#3486
@gayyappan gayyappan marked this pull request as ready for review August 16, 2021 22:05
@gayyappan gayyappan requested a review from a team as a code owner August 16, 2021 22:05
@gayyappan gayyappan requested review from pmwkaa, afiskon, erimatnor and svenklemm and removed request for a team August 16, 2021 22:05
@gayyappan gayyappan self-assigned this Aug 16, 2021
@afiskon
Copy link
Contributor

afiskon commented Aug 17, 2021

Looks OK but don't we have to add a test on this?

@mkindahl mkindahl merged commit a77f972 into timescale:master Aug 17, 2021
@mkindahl mkindahl mentioned this pull request Aug 19, 2021
Closed
mkindahl added a commit to mkindahl/timescaledb that referenced this pull request Aug 19, 2021
@mkindahl
Release 2.4.1
facea96 
This release contains bug fixes since the 2.4.0 release.  We deem it
high priority to upgrade.

The release fixes continous aggregate refresh for postgres 12.8 and
13.4, a crash with ALTER TABLE commands and a crash with continuous
aggregates with HAVING clause.

**Bugfixes**
* timescale#3430 Fix havingqual processing for continuous aggregates
* timescale#3468 Disable tests by default if tools are not found
* timescale#3462 Fix crash while tracking alter table commands
* timescale#3489 Fix continuous agg bgw job failure for PG 12.8 and 13.4
* timescale#3494 Improve error message when adding data nodes

**Thanks**
* @brianbenns for reporting a segfault with continuous aggregates
* @brianbenns for reporting a segfault with continuous aggregates
* @usego for reporting an issue with continuous aggregate refresh on PG 13.4
mkindahl added a commit that referenced this pull request Aug 19, 2021
@mkindahl
Release 2.4.1
4e0954e 
This release contains bug fixes since the 2.4.0 release.  We deem it
high priority to upgrade.

The release fixes continous aggregate refresh for postgres 12.8 and
13.4, a crash with ALTER TABLE commands and a crash with continuous
aggregates with HAVING clause.

**Bugfixes**
* #3430 Fix havingqual processing for continuous aggregates
* #3468 Disable tests by default if tools are not found
* #3462 Fix crash while tracking alter table commands
* #3489 Fix continuous agg bgw job failure for PG 12.8 and 13.4
* #3494 Improve error message when adding data nodes

**Thanks**
* @brianbenns for reporting a segfault with continuous aggregates
* @brianbenns for reporting a segfault with continuous aggregates
* @usego for reporting an issue with continuous aggregate refresh on PG 13.4
mkindahl added a commit to mkindahl/timescaledb that referenced this pull request Aug 19, 2021
@mkindahl
Release 2.4.1
dd29b85 
This release contains bug fixes since the 2.4.0 release.  We deem it
high priority to upgrade.

The release fixes continous aggregate refresh for postgres 12.8 and
13.4, a crash with ALTER TABLE commands and a crash with continuous
aggregates with HAVING clause.

**Bugfixes**
* timescale#3430 Fix havingqual processing for continuous aggregates
* timescale#3468 Disable tests by default if tools are not found
* timescale#3462 Fix crash while tracking alter table commands
* timescale#3489 Fix continuous agg bgw job failure for PG 12.8 and 13.4
* timescale#3494 Improve error message when adding data nodes

**Thanks**
* @brianbenns for reporting a segfault with continuous aggregates
* @brianbenns for reporting a segfault with continuous aggregates
* @usego for reporting an issue with continuous aggregate refresh on PG 13.4
mkindahl added a commit that referenced this pull request Aug 19, 2021
@mkindahl
Release 2.4.1
818a232 
This release contains bug fixes since the 2.4.0 release.  We deem it
high priority to upgrade.

The release fixes continous aggregate refresh for postgres 12.8 and
13.4, a crash with ALTER TABLE commands and a crash with continuous
aggregates with HAVING clause.

**Bugfixes**
* #3430 Fix havingqual processing for continuous aggregates
* #3468 Disable tests by default if tools are not found
* #3462 Fix crash while tracking alter table commands
* #3489 Fix continuous agg bgw job failure for PG 12.8 and 13.4
* #3494 Improve error message when adding data nodes

**Thanks**
* @brianbenns for reporting a segfault with continuous aggregates
* @usego for reporting an issue with continuous aggregate refresh on PG 13.4
mkindahl added a commit that referenced this pull request Aug 19, 2021
@mkindahl
Release 2.4.1
63a6585 
This release contains bug fixes since the 2.4.0 release.  We deem it
high priority to upgrade.

The release fixes continous aggregate refresh for postgres 12.8 and
13.4, a crash with ALTER TABLE commands and a crash with continuous
aggregates with HAVING clause.

**Bugfixes**
* #3430 Fix havingqual processing for continuous aggregates
* #3468 Disable tests by default if tools are not found
* #3462 Fix crash while tracking alter table commands
* #3489 Fix continuous agg bgw job failure for PG 12.8 and 13.4
* #3494 Improve error message when adding data nodes

**Thanks**
* @brianbenns for reporting a segfault with continuous aggregates
* @brianbenns for reporting a segfault with continuous aggregates
* @usego for reporting an issue with continuous aggregate refresh on PG 13.4
@mkindahl mkindahl mentioned this pull request Nov 11, 2021
Closed
adam8157 added a commit to greenplum-db/gpdb-postgres-merge-Archived that referenced this pull request Nov 28, 2022
@adam8157
Fix extended_protocol_commit_test in another way
8b685ad 
reference: timescale/timescaledb#3489
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afiskon afiskon afiskon approved these changes

@mkindahl mkindahl mkindahl approved these changes

@pmwkaa pmwkaa Awaiting requested review from pmwkaa

@erimatnor erimatnor Awaiting requested review from erimatnor

@svenklemm svenklemm Awaiting requested review from svenklemm

Assignees

@gayyappan gayyappan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gayyappan @afiskon @mkindahl