Support timezones in time_bucket_ng() #3505

afiskon · 2021-08-20T12:47:43Z

This patch adds support of timezones in time_bucket_ng(). The 'origin'
argument can't be used with timezones yet. This will be implemented in
a separate pull request.

The volatility of time_bucket_ng() is kept as is, although there is
a discussion in the progress of making it IMMUTABLE. This will be
addressed in a separate PR as well.

sql/time_bucket_ng.sql

svenklemm

seems to only work for timestamptz after the year 2000
bench=# select timescaledb_experimental.time_bucket_ng('1d','1990-01-01','UTC');
ERROR: 22023: origin must be before the given date
CONTEXT: SQL statement "SELECT timescaledb_experimental.time_bucket_ng(
bucket_width,
ts at time zone timezone)"
PL/pgSQL function timescaledb_experimental.time_bucket_ng(interval,timestamp with time zone,text) line 7 at SQL statement
LOCATION: ts_time_bucket_ng_date, time_bucket.c:453
Time: 0.983 ms

afiskon · 2021-08-26T07:54:13Z

seems to only work for timestamptz after the year 2000

This is intentional, because we don't support going backward from origin, see "Open Issues" in RFC. In short - it doesn't make sense in the general case for variable-sized buckets and it seems to be a bad user experience to support it depending on the arguments. There will be a follow-up patch that allows overriding the default origin that solves this problem.

I will make this behavior more clear from the documentation.

UPD - corresponding PR timescale/docs#308

sql/time_bucket_ng.sql

test/sql/timestamp.sql

codecov · 2021-08-27T10:06:40Z

Codecov Report

Merging #3505 (59f36a3) into master (f7eceba) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 59f36a3 differs from pull request most recent head 77766d6. Consider uploading reports for the commit 77766d6 to get more accurate results

@@           Coverage Diff           @@
##           master    #3505   +/-   ##
=======================================
  Coverage   90.70%   90.70%           
=======================================
  Files         212      212           
  Lines       36278    36289   +11     
=======================================
+ Hits        32906    32917   +11     
  Misses       3372     3372

Impacted Files	Coverage Δ
src/adts/bit_array_impl.h	`97.27% <ø> (ø)`
src/bgw/job.c	`91.63% <ø> (ø)`
src/bgw/launcher_interface.c	`72.22% <ø> (ø)`
src/bgw/scheduler.c	`83.04% <ø> (ø)`
src/bgw/timer.c	`66.66% <ø> (ø)`
src/bgw_policy/chunk_stats.c	`80.00% <ø> (ø)`
src/cache.c	`89.78% <ø> (ø)`
src/cache_invalidate.c	`85.41% <ø> (ø)`
src/catalog.c	`84.61% <ø> (ø)`
src/chunk.c	`96.12% <ø> (ø)`
... and 76 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76ad386...77766d6. Read the comment docs.

src/time_bucket.c

test/expected/timestamp.out

svenklemm

Would be good to have tests for timestamps < 2000

.gitignore

sql/time_bucket_ng.sql

sql/updates/reverse-dev.sql

This patch adds support of timezones in time_bucket_ng(). The 'origin' argument can't be used with timezones yet. This will be implemented in a separate pull request.

@binakot

This release adds major new features since the 2.4.2 release. We deem it moderate priority for upgrading This release adds several and long-awaited/wanted features: * Continuous Aggregates for Distributed Hypertables * Support for PostgreSQL 14 * Experimental: Support for timezones in `time_bucket_ng()`, including the `origin` argument This release also includes several bug fixes. **Major Features** * timescale#3435 Add continuous aggregates for distributed hypertables * timescale#3034 Add support for PostgreSQL 14 * timescale#3505 Add support for timezones in `time_bucket_ng()` **Minor Features** * timescale#3598 Improve evaluation of stable functions such as now() on access node **Bugfixes** * timescale#3580 Fix memory context bug executing TRUNCATE * timescale#3654 Fix index attnum mapping in reorder_chunk * timescale#3661 Fix SkipScan path generation with constant DISTINCT column * timescale#3708 Fix crash in get_aggsplit * timescale#3709 Fix ordered append pathkey check * timescale#3728 Fix SkipScan with varchar column **Thanks** * @binakot and @sebvett for reporting an issue with DISTINCT queries * @hardikm10, @DavidPavlicek and @pafiti for reporting bugs on TRUNCATE * @mjf for reporting an issue with ordered append and JOINs * @phemmer for reporting the issues on multinode with aggregate queries and evaluation of now() Disable-check: commit-count

@binakot

This release adds major new features since the 2.4.2 release. We deem it moderate priority for upgrading This release adds several and long-awaited/wanted features: * Continuous Aggregates for Distributed Hypertables * Support for PostgreSQL 14 * Experimental: Support for timezones in `time_bucket_ng()`, including the `origin` argument This release also includes several bug fixes. **Major Features** * timescale#3435 Add continuous aggregates for distributed hypertables * timescale#3034 Add support for PostgreSQL 14 * timescale#3505 Add support for timezones in `time_bucket_ng()` **Minor Features** * timescale#3598 Improve evaluation of stable functions such as now() on access node **Bugfixes** * timescale#3580 Fix memory context bug executing TRUNCATE * timescale#3654 Fix index attnum mapping in reorder_chunk * timescale#3661 Fix SkipScan path generation with constant DISTINCT column * timescale#3708 Fix crash in get_aggsplit * timescale#3709 Fix ordered append pathkey check * timescale#3728 Fix SkipScan with varchar column **Thanks** * @binakot and @sebvett for reporting an issue with DISTINCT queries * @hardikm10, @DavidPavlicek and @pafiti for reporting bugs on TRUNCATE * @mjf for reporting an issue with ordered append and JOINs * @phemmer for reporting the issues on multinode with aggregate queries and evaluation of now() Disable-check: commit-count

@binakot

This release adds major new features since the 2.4.2 release. We deem it moderate priority for upgrading This release adds several and long-awaited/wanted features: * Continuous Aggregates for Distributed Hypertables * Support for PostgreSQL 14 * Experimental: Support for timezones in `time_bucket_ng()`, including the `origin` argument This release also includes several bug fixes. **Major Features** * timescale#3435 Add continuous aggregates for distributed hypertables * timescale#3034 Add support for PostgreSQL 14 * timescale#3505 Add support for timezones in `time_bucket_ng()` **Minor Features** * timescale#3598 Improve evaluation of stable functions such as now() on access node **Bugfixes** * timescale#3580 Fix memory context bug executing TRUNCATE * timescale#3654 Fix index attnum mapping in reorder_chunk * timescale#3661 Fix SkipScan path generation with constant DISTINCT column * timescale#3708 Fix crash in get_aggsplit * timescale#3709 Fix ordered append pathkey check * timescale#3728 Fix SkipScan with varchar column **Thanks** * @binakot and @sebvett for reporting an issue with DISTINCT queries * @hardikm10, @DavidPavlicek and @pafiti for reporting bugs on TRUNCATE * @mjf for reporting an issue with ordered append and JOINs * @phemmer for reporting the issues on multinode with aggregate queries and evaluation of now() Disable-check: commit-count

@binakot

This release adds major new features since the 2.4.2 release. We deem it moderate priority for upgrading This release adds several and long-awaited/wanted features: * Continuous Aggregates for Distributed Hypertables * Support for PostgreSQL 14 * Experimental: Support for timezones in `time_bucket_ng()`, including the `origin` argument This release also includes several bug fixes. **Major Features** * timescale#3435 Add continuous aggregates for distributed hypertables * timescale#3034 Add support for PostgreSQL 14 * timescale#3505 Add support for timezones in `time_bucket_ng()` **Minor Features** * timescale#3598 Improve evaluation of stable functions such as now() on access node **Bugfixes** * timescale#3580 Fix memory context bug executing TRUNCATE * timescale#3654 Fix index attnum mapping in reorder_chunk * timescale#3661 Fix SkipScan path generation with constant DISTINCT column * timescale#3708 Fix crash in get_aggsplit * timescale#3709 Fix ordered append pathkey check * timescale#3728 Fix SkipScan with varchar column **Thanks** * @binakot and @sebvett for reporting an issue with DISTINCT queries * @hardikm10, @DavidPavlicek and @pafiti for reporting bugs on TRUNCATE * @mjf for reporting an issue with ordered append and JOINs * @phemmer for reporting the issues on multinode with aggregate queries and evaluation of now() Disable-check: commit-count

@binakot

This release adds major new features since the 2.4.2 release. We deem it moderate priority for upgrading This release adds several and long-awaited/wanted features: * Continuous Aggregates for Distributed Hypertables * Support for PostgreSQL 14 * Experimental: Support for timezones in `time_bucket_ng()`, including the `origin` argument This release also includes several bug fixes. **Major Features** * timescale#3435 Add continuous aggregates for distributed hypertables * timescale#3034 Add support for PostgreSQL 14 * timescale#3505 Add support for timezones in `time_bucket_ng()` **Minor Features** * timescale#3598 Improve evaluation of stable functions such as now() on access node **Bugfixes** * timescale#3580 Fix memory context bug executing TRUNCATE * timescale#3654 Fix index attnum mapping in reorder_chunk * timescale#3661 Fix SkipScan path generation with constant DISTINCT column * timescale#3708 Fix crash in get_aggsplit * timescale#3709 Fix ordered append pathkey check * timescale#3728 Fix SkipScan with varchar column **Thanks** * @binakot and @sebvett for reporting an issue with DISTINCT queries * @hardikm10, @DavidPavlicek and @pafiti for reporting bugs on TRUNCATE * @mjf for reporting an issue with ordered append and JOINs * @phemmer for reporting the issues on multinode with aggregate queries and evaluation of now() Disable-check: commit-count

@binakot

This release adds major new features since the 2.4.2 release. We deem it moderate priority for upgrading. This release includes these noteworthy features: * Continuous Aggregates for Distributed Hypertables * Support for PostgreSQL 14 * Experimental: Support for timezones in `time_bucket_ng()`, including the `origin` argument This release also includes several bug fixes. **Features** * timescale#3034 Add support for PostgreSQL 14 * timescale#3435 Add continuous aggregates for distributed hypertables * timescale#3505 Add support for timezones in `time_bucket_ng()` * timescale#3598 Improve evaluation of stable functions such as now() on access node * timescale#3717 Support transparent decompression on individual chunks **Bugfixes** * timescale#3580 Fix memory context bug executing TRUNCATE * timescale#3592 Allow alter column type on distributed hypertable * timescale#3618 Fix execution of refresh_caggs from user actions * timescale#3625 Add shared dependencies when creating chunk * timescale#3626 Fix memory context bug executing TRUNCATE * timescale#3627 Schema qualify UDTs in multi-node * timescale#3638 Allow owner change of a data node * timescale#3654 Fix index attnum mapping in reorder_chunk * timescale#3661 Fix SkipScan path generation with constant DISTINCT column * timescale#3667 Fix compress_policy for multi txn handling * timescale#3673 Fix distributed hypertable DROP within a procedure * timescale#3701 Allow anyone to use size utilities on distributed hypertables * timescale#3708 Fix crash in get_aggsplit * timescale#3709 Fix ordered append pathkey check * timescale#3712 Fix GRANT/REVOKE ALL IN SCHEMA handling * timescale#3724 Fix inserts into compressed chunks on hypertables with caggs * timescale#3727 Fix DirectFunctionCall crash in distributed_exec * timescale#3728 Fix SkipScan with varchar column * timescale#3733 Fix ANALYZE crash with custom statistics for custom types * timescale#3747 Always reset expr context in DecompressChunk **Thanks** * @binakot and @sebvett for reporting an issue with DISTINCT queries * @hardikm10, @DavidPavlicek and @pafiti for reporting bugs on TRUNCATE * @mjf for reporting an issue with ordered append and JOINs * @phemmer for reporting the issues on multinode with aggregate queries and evaluation of now() * @abolognino for reporting an issue with INSERTs into compressed hypertables that have cagg * @tanglebones for reporting the ANALYZE crash with custom types on multinode

@binakot

This release adds major new features since the 2.4.2 release. We deem it moderate priority for upgrading. This release includes these noteworthy features: * Continuous Aggregates for Distributed Hypertables * Support for PostgreSQL 14 * Experimental: Support for timezones in `time_bucket_ng()`, including the `origin` argument This release also includes several bug fixes. **Features** * timescale#3034 Add support for PostgreSQL 14 * timescale#3435 Add continuous aggregates for distributed hypertables * timescale#3505 Add support for timezones in `time_bucket_ng()` **Bugfixes** * timescale#3580 Fix memory context bug executing TRUNCATE * timescale#3592 Allow alter column type on distributed hypertable * timescale#3598 Improve evaluation of stable functions such as now() on access node * timescale#3618 Fix execution of refresh_caggs from user actions * timescale#3625 Add shared dependencies when creating chunk * timescale#3626 Fix memory context bug executing TRUNCATE * timescale#3627 Schema qualify UDTs in multi-node * timescale#3638 Allow owner change of a data node * timescale#3654 Fix index attnum mapping in reorder_chunk * timescale#3661 Fix SkipScan path generation with constant DISTINCT column * timescale#3667 Fix compress_policy for multi txn handling * timescale#3673 Fix distributed hypertable DROP within a procedure * timescale#3701 Allow anyone to use size utilities on distributed hypertables * timescale#3708 Fix crash in get_aggsplit * timescale#3709 Fix ordered append pathkey check * timescale#3712 Fix GRANT/REVOKE ALL IN SCHEMA handling * timescale#3717 Support transparent decompression on individual chunks * timescale#3724 Fix inserts into compressed chunks on hypertables with caggs * timescale#3727 Fix DirectFunctionCall crash in distributed_exec * timescale#3728 Fix SkipScan with varchar column * timescale#3733 Fix ANALYZE crash with custom statistics for custom types * timescale#3747 Always reset expr context in DecompressChunk **Thanks** * @binakot and @sebvett for reporting an issue with DISTINCT queries * @hardikm10, @DavidPavlicek and @pafiti for reporting bugs on TRUNCATE * @mjf for reporting an issue with ordered append and JOINs * @phemmer for reporting the issues on multinode with aggregate queries and evaluation of now() * @abolognino for reporting an issue with INSERTs into compressed hypertables that have cagg * @tanglebones for reporting the ANALYZE crash with custom types on multinode

@binakot

This release adds major new features since the 2.4.2 release. We deem it moderate priority for upgrading. This release includes these noteworthy features: * Continuous Aggregates for Distributed Hypertables * Support for PostgreSQL 14 * Experimental: Support for timezones in `time_bucket_ng()`, including the `origin` argument This release also includes several bug fixes. **Features** * #3034 Add support for PostgreSQL 14 * #3435 Add continuous aggregates for distributed hypertables * #3505 Add support for timezones in `time_bucket_ng()` **Bugfixes** * #3580 Fix memory context bug executing TRUNCATE * #3592 Allow alter column type on distributed hypertable * #3598 Improve evaluation of stable functions such as now() on access node * #3618 Fix execution of refresh_caggs from user actions * #3625 Add shared dependencies when creating chunk * #3626 Fix memory context bug executing TRUNCATE * #3627 Schema qualify UDTs in multi-node * #3638 Allow owner change of a data node * #3654 Fix index attnum mapping in reorder_chunk * #3661 Fix SkipScan path generation with constant DISTINCT column * #3667 Fix compress_policy for multi txn handling * #3673 Fix distributed hypertable DROP within a procedure * #3701 Allow anyone to use size utilities on distributed hypertables * #3708 Fix crash in get_aggsplit * #3709 Fix ordered append pathkey check * #3712 Fix GRANT/REVOKE ALL IN SCHEMA handling * #3717 Support transparent decompression on individual chunks * #3724 Fix inserts into compressed chunks on hypertables with caggs * #3727 Fix DirectFunctionCall crash in distributed_exec * #3728 Fix SkipScan with varchar column * #3733 Fix ANALYZE crash with custom statistics for custom types * #3747 Always reset expr context in DecompressChunk **Thanks** * @binakot and @sebvett for reporting an issue with DISTINCT queries * @hardikm10, @DavidPavlicek and @pafiti for reporting bugs on TRUNCATE * @mjf for reporting an issue with ordered append and JOINs * @phemmer for reporting the issues on multinode with aggregate queries and evaluation of now() * @abolognino for reporting an issue with INSERTs into compressed hypertables that have cagg * @tanglebones for reporting the ANALYZE crash with custom types on multinode

@binakot

This release adds major new features since the 2.4.2 release. We deem it moderate priority for upgrading. This release includes these noteworthy features: * Continuous Aggregates for Distributed Hypertables * Support for PostgreSQL 14 * Experimental: Support for timezones in `time_bucket_ng()`, including the `origin` argument This release also includes several bug fixes. **Features** * #3034 Add support for PostgreSQL 14 * #3435 Add continuous aggregates for distributed hypertables * #3505 Add support for timezones in `time_bucket_ng()` **Bugfixes** * #3580 Fix memory context bug executing TRUNCATE * #3592 Allow alter column type on distributed hypertable * #3598 Improve evaluation of stable functions such as now() on access node * #3618 Fix execution of refresh_caggs from user actions * #3625 Add shared dependencies when creating chunk * #3626 Fix memory context bug executing TRUNCATE * #3627 Schema qualify UDTs in multi-node * #3638 Allow owner change of a data node * #3654 Fix index attnum mapping in reorder_chunk * #3661 Fix SkipScan path generation with constant DISTINCT column * #3667 Fix compress_policy for multi txn handling * #3673 Fix distributed hypertable DROP within a procedure * #3701 Allow anyone to use size utilities on distributed hypertables * #3708 Fix crash in get_aggsplit * #3709 Fix ordered append pathkey check * #3712 Fix GRANT/REVOKE ALL IN SCHEMA handling * #3717 Support transparent decompression on individual chunks * #3724 Fix inserts into compressed chunks on hypertables with caggs * #3727 Fix DirectFunctionCall crash in distributed_exec * #3728 Fix SkipScan with varchar column * #3733 Fix ANALYZE crash with custom statistics for custom types * #3747 Always reset expr context in DecompressChunk **Thanks** * @binakot and @sebvett for reporting an issue with DISTINCT queries * @hardikm10, @DavidPavlicek and @pafiti for reporting bugs on TRUNCATE * @mjf for reporting an issue with ordered append and JOINs * @phemmer for reporting the issues on multinode with aggregate queries and evaluation of now() * @abolognino for reporting an issue with INSERTs into compressed hypertables that have cagg * @tanglebones for reporting the ANALYZE crash with custom types on multinode

@binakot

This release adds major new features since the 2.4.2 release. We deem it moderate priority for upgrading. This release includes these noteworthy features: * Continuous Aggregates for Distributed Hypertables * Support for PostgreSQL 14 * Experimental: Support for timezones in `time_bucket_ng()`, including the `origin` argument This release also includes several bug fixes. **Features** * #3034 Add support for PostgreSQL 14 * #3435 Add continuous aggregates for distributed hypertables * #3505 Add support for timezones in `time_bucket_ng()` **Bugfixes** * #3580 Fix memory context bug executing TRUNCATE * #3592 Allow alter column type on distributed hypertable * #3598 Improve evaluation of stable functions such as now() on access node * #3618 Fix execution of refresh_caggs from user actions * #3625 Add shared dependencies when creating chunk * #3626 Fix memory context bug executing TRUNCATE * #3627 Schema qualify UDTs in multi-node * #3638 Allow owner change of a data node * #3654 Fix index attnum mapping in reorder_chunk * #3661 Fix SkipScan path generation with constant DISTINCT column * #3667 Fix compress_policy for multi txn handling * #3673 Fix distributed hypertable DROP within a procedure * #3701 Allow anyone to use size utilities on distributed hypertables * #3708 Fix crash in get_aggsplit * #3709 Fix ordered append pathkey check * #3712 Fix GRANT/REVOKE ALL IN SCHEMA handling * #3717 Support transparent decompression on individual chunks * #3724 Fix inserts into compressed chunks on hypertables with caggs * #3727 Fix DirectFunctionCall crash in distributed_exec * #3728 Fix SkipScan with varchar column * #3733 Fix ANALYZE crash with custom statistics for custom types * #3747 Always reset expr context in DecompressChunk **Thanks** * @binakot and @sebvett for reporting an issue with DISTINCT queries * @hardikm10, @DavidPavlicek and @pafiti for reporting bugs on TRUNCATE * @mjf for reporting an issue with ordered append and JOINs * @phemmer for reporting the issues on multinode with aggregate queries and evaluation of now() * @abolognino for reporting an issue with INSERTs into compressed hypertables that have cagg * @tanglebones for reporting the ANALYZE crash with custom types on multinode

@binakot

This release adds major new features since the 2.4.2 release. We deem it moderate priority for upgrading. This release includes these noteworthy features: * Continuous Aggregates for Distributed Hypertables * Support for PostgreSQL 14 * Experimental: Support for timezones in `time_bucket_ng()`, including the `origin` argument This release also includes several bug fixes. **Features** * #3034 Add support for PostgreSQL 14 * #3435 Add continuous aggregates for distributed hypertables * #3505 Add support for timezones in `time_bucket_ng()` **Bugfixes** * #3580 Fix memory context bug executing TRUNCATE * #3592 Allow alter column type on distributed hypertable * #3598 Improve evaluation of stable functions such as now() on access node * #3618 Fix execution of refresh_caggs from user actions * #3625 Add shared dependencies when creating chunk * #3626 Fix memory context bug executing TRUNCATE * #3627 Schema qualify UDTs in multi-node * #3638 Allow owner change of a data node * #3654 Fix index attnum mapping in reorder_chunk * #3661 Fix SkipScan path generation with constant DISTINCT column * #3667 Fix compress_policy for multi txn handling * #3673 Fix distributed hypertable DROP within a procedure * #3701 Allow anyone to use size utilities on distributed hypertables * #3708 Fix crash in get_aggsplit * #3709 Fix ordered append pathkey check * #3712 Fix GRANT/REVOKE ALL IN SCHEMA handling * #3717 Support transparent decompression on individual chunks * #3724 Fix inserts into compressed chunks on hypertables with caggs * #3727 Fix DirectFunctionCall crash in distributed_exec * #3728 Fix SkipScan with varchar column * #3733 Fix ANALYZE crash with custom statistics for custom types * #3747 Always reset expr context in DecompressChunk **Thanks** * @binakot and @sebvett for reporting an issue with DISTINCT queries * @hardikm10, @DavidPavlicek and @pafiti for reporting bugs on TRUNCATE * @mjf for reporting an issue with ordered append and JOINs * @phemmer for reporting the issues on multinode with aggregate queries and evaluation of now() * @abolognino for reporting an issue with INSERTs into compressed hypertables that have cagg * @tanglebones for reporting the ANALYZE crash with custom types on multinode

afiskon requested review from mkindahl, svenklemm and mfundul August 20, 2021 12:47

afiskon requested a review from a team as a code owner August 20, 2021 12:47

afiskon force-pushed the time_bucket_ng_timezones branch 2 times, most recently from 636f9ad to ee8bfa2 Compare August 20, 2021 12:58

afiskon self-assigned this Aug 20, 2021

afiskon force-pushed the time_bucket_ng_timezones branch from ee8bfa2 to 96a72ba Compare August 23, 2021 11:30

afiskon enabled auto-merge (rebase) August 23, 2021 11:30

afiskon force-pushed the time_bucket_ng_timezones branch 2 times, most recently from 9a51dfb to 79ce651 Compare August 24, 2021 12:12

afiskon requested a review from gayyappan August 25, 2021 13:18

svenklemm reviewed Aug 25, 2021

View reviewed changes

sql/time_bucket_ng.sql Outdated Show resolved Hide resolved

mfundul reviewed Aug 25, 2021

View reviewed changes

sql/time_bucket_ng.sql Outdated Show resolved Hide resolved

svenklemm reviewed Aug 25, 2021

View reviewed changes

mkindahl reviewed Aug 26, 2021

View reviewed changes

sql/time_bucket_ng.sql Outdated Show resolved Hide resolved

sql/time_bucket_ng.sql Outdated Show resolved Hide resolved

sql/time_bucket_ng.sql Outdated Show resolved Hide resolved

test/sql/timestamp.sql Outdated Show resolved Hide resolved

afiskon mentioned this pull request Aug 26, 2021

Clarify the behavior of time_bucket_ng() in respect of origin argument timescale/docs#308

Merged

3 tasks

afiskon force-pushed the time_bucket_ng_timezones branch 6 times, most recently from 60d27ed to 02b7adb Compare August 27, 2021 09:52

afiskon requested review from mkindahl, mfundul and svenklemm August 27, 2021 10:34

svenklemm reviewed Aug 30, 2021

View reviewed changes

src/time_bucket.c Outdated Show resolved Hide resolved

afiskon force-pushed the time_bucket_ng_timezones branch from 02b7adb to 509c85b Compare August 30, 2021 08:45

svenklemm reviewed Aug 30, 2021

View reviewed changes

src/time_bucket.c Outdated Show resolved Hide resolved

svenklemm reviewed Aug 30, 2021

View reviewed changes

test/expected/timestamp.out Outdated Show resolved Hide resolved

svenklemm reviewed Aug 30, 2021

View reviewed changes

afiskon force-pushed the time_bucket_ng_timezones branch 3 times, most recently from 8a6b7e2 to 56fa4e1 Compare August 30, 2021 16:20

afiskon requested a review from svenklemm August 30, 2021 16:37

afiskon force-pushed the time_bucket_ng_timezones branch from 56fa4e1 to 4f3f42b Compare August 31, 2021 08:15

mkindahl reviewed Aug 31, 2021

View reviewed changes

.gitignore Outdated Show resolved Hide resolved

sql/time_bucket_ng.sql Outdated Show resolved Hide resolved

sql/time_bucket_ng.sql Outdated Show resolved Hide resolved

sql/updates/reverse-dev.sql Outdated Show resolved Hide resolved

afiskon force-pushed the time_bucket_ng_timezones branch from 4f3f42b to 59f36a3 Compare August 31, 2021 13:06

afiskon requested a review from mkindahl August 31, 2021 13:17

svenklemm approved these changes Aug 31, 2021

View reviewed changes

mkindahl approved these changes Sep 1, 2021

View reviewed changes

Support timezones in time_bucket_ng()

77766d6

This patch adds support of timezones in time_bucket_ng(). The 'origin' argument can't be used with timezones yet. This will be implemented in a separate pull request.

afiskon force-pushed the time_bucket_ng_timezones branch from 59f36a3 to 77766d6 Compare September 1, 2021 08:09

afiskon merged commit 22e77a7 into timescale:master Sep 1, 2021

afiskon deleted the time_bucket_ng_timezones branch September 1, 2021 10:16

fabriziomello mentioned this pull request Oct 26, 2021

Release 2.5.0 #3744

Merged

pfried mentioned this pull request Oct 29, 2021

Support for month, year and time zones in time_bucket #414

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support timezones in time_bucket_ng() #3505

Support timezones in time_bucket_ng() #3505

afiskon commented Aug 20, 2021 •

edited

Loading

svenklemm left a comment

afiskon commented Aug 26, 2021 •

edited

Loading

codecov bot commented Aug 27, 2021 •

edited

Loading

svenklemm left a comment

Support timezones in time_bucket_ng() #3505

Support timezones in time_bucket_ng() #3505

Conversation

afiskon commented Aug 20, 2021 • edited Loading

svenklemm left a comment

Choose a reason for hiding this comment

afiskon commented Aug 26, 2021 • edited Loading

codecov bot commented Aug 27, 2021 • edited Loading

Codecov Report

svenklemm left a comment

Choose a reason for hiding this comment

afiskon commented Aug 20, 2021 •

edited

Loading

afiskon commented Aug 26, 2021 •

edited

Loading

codecov bot commented Aug 27, 2021 •

edited

Loading