Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix race in bgw_db_scheduler_fixed #4970

Merged
merged 1 commit into from
Nov 14, 2022

Conversation

mkindahl
Copy link
Contributor

When deleting a job in the test, the job does not necessarily terminate immediately, so wait for a log entries from the job before checking the jobs table.

Fixed #4859

@mkindahl mkindahl self-assigned this Nov 14, 2022
@mkindahl mkindahl marked this pull request as ready for review November 14, 2022 11:50
@codecov
Copy link

codecov bot commented Nov 14, 2022

Codecov Report

Merging #4970 (cf92dd8) into main (e4ba2bc) will increase coverage by 0.02%.
The diff coverage is 98.49%.

❗ Current head cf92dd8 differs from pull request most recent head 1573175. Consider uploading reports for the commit 1573175 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4970      +/-   ##
==========================================
+ Coverage   89.50%   89.52%   +0.02%     
==========================================
  Files         226      226              
  Lines       50822    50999     +177     
==========================================
+ Hits        45488    45658     +170     
- Misses       5334     5341       +7     
Impacted Files Coverage Δ
src/ts_catalog/catalog.c 85.91% <ø> (ø)
src/ts_catalog/catalog.h 100.00% <ø> (ø)
src/utils.h 80.00% <ø> (ø)
tsl/src/init.c 96.00% <ø> (ø)
tsl/src/chunk.c 94.76% <96.15%> (+0.02%) ⬆️
tsl/src/data_node.c 96.06% <99.04%> (+0.70%) ⬆️
src/cross_module_fn.c 68.13% <100.00%> (+0.17%) ⬆️
src/hypertable.c 87.42% <100.00%> (+0.07%) ⬆️
src/process_utility.c 90.26% <100.00%> (+0.08%) ⬆️
src/ts_catalog/chunk_data_node.c 99.37% <100.00%> (+0.02%) ⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2b7c76...1573175. Read the comment docs.

When deleting a job in the test, the job does not necessarily terminate
immediately, so wait for a log entries from the job before checking the
jobs table.

Fixed timescale#4859
@mkindahl mkindahl enabled auto-merge (rebase) November 14, 2022 12:05
@mkindahl mkindahl merged commit 141e114 into timescale:main Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Flaky test] Lingering job in bgw_db_scheduler_fixed
3 participants