-
Notifications
You must be signed in to change notification settings - Fork 848
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move freeze/unfreeze chunk to tsl #4974
Conversation
efda6ef
to
f03a7b8
Compare
Codecov Report
@@ Coverage Diff @@
## main #4974 +/- ##
===========================================
+ Coverage 63.01% 89.65% +26.64%
===========================================
Files 226 226
Lines 45069 51173 +6104
===========================================
+ Hits 28400 45879 +17479
+ Misses 16669 5294 -11375
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One question, rest LGTM.
@@ -3549,6 +3547,17 @@ ts_chunk_unset_frozen(Chunk *chunk) | |||
#endif | |||
} | |||
|
|||
bool | |||
ts_chunk_is_frozen(Chunk *chunk) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this exported function intended for later use? I could not find any calls at the moment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
called from the tsl code.
f03a7b8
to
6aba28e
Compare
Move code for freeze and unfreeze chunk to tsl directory.
6aba28e
to
d1db8c7
Compare
Move code for freeze and unfreeze chunk to tsl directory.