Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move freeze/unfreeze chunk to tsl #4974

Merged
merged 1 commit into from
Nov 17, 2022
Merged

Conversation

gayyappan
Copy link
Contributor

Move code for freeze and unfreeze chunk to tsl directory.

@codecov
Copy link

codecov bot commented Nov 14, 2022

Codecov Report

Merging #4974 (d1db8c7) into main (7e4ebd1) will increase coverage by 26.64%.
The diff coverage is 94.11%.

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #4974       +/-   ##
===========================================
+ Coverage   63.01%   89.65%   +26.64%     
===========================================
  Files         226      226               
  Lines       45069    51173     +6104     
===========================================
+ Hits        28400    45879    +17479     
+ Misses      16669     5294    -11375     
Impacted Files Coverage Δ
src/chunk.h 100.00% <ø> (+100.00%) ⬆️
src/func_cache.c 91.45% <ø> (+1.25%) ⬆️
tsl/src/init.c 96.00% <ø> (+40.00%) ⬆️
src/chunk.c 91.53% <50.00%> (+80.99%) ⬆️
tsl/src/chunk.c 93.60% <85.71%> (-2.33%) ⬇️
src/cross_module_fn.c 68.47% <100.00%> (+66.81%) ⬆️
src/nodes/chunk_dispatch_state.c 94.00% <100.00%> (+74.68%) ⬆️
src/nodes/chunk_insert_state.c 97.20% <100.00%> (-0.47%) ⬇️
src/time_bucket.c 95.81% <100.00%> (-2.58%) ⬇️
tsl/src/compression/compression.c 96.32% <100.00%> (+0.52%) ⬆️
... and 213 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bfa641a...d1db8c7. Read the comment docs.

@gayyappan gayyappan marked this pull request as ready for review November 14, 2022 19:03
Copy link
Contributor

@jnidzwetzki jnidzwetzki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question, rest LGTM.

@@ -3549,6 +3547,17 @@ ts_chunk_unset_frozen(Chunk *chunk)
#endif
}

bool
ts_chunk_is_frozen(Chunk *chunk)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this exported function intended for later use? I could not find any calls at the moment.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

called from the tsl code.

Move code for freeze and unfreeze chunk to tsl directory.
@gayyappan gayyappan enabled auto-merge (rebase) November 17, 2022 19:35
@gayyappan gayyappan merged commit b9ca06d into timescale:main Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants