Allow pushdown of reference table joins #5212

jnidzwetzki · 2023-01-24T09:08:58Z

This patch adds the functionality that is needed to perform distributed, parallel joins on reference tables on access nodes. This code allows the pushdown of a join if:

(1) The setting "ts_guc_enable_per_data_node_queries" is enabled
(2) The outer relation is a distributed hypertable
(3) The inner relation is marked as a reference table
(4) The join is a left join or an inner join

codecov · 2023-01-24T09:23:00Z

Codecov Report

Merging #5212 (788d671) into main (f12a361) will increase coverage by 0.17%.
The diff coverage is 97.17%.

@@            Coverage Diff             @@
##             main    #5212      +/-   ##
==========================================
+ Coverage   90.71%   90.89%   +0.17%     
==========================================
  Files         225      225              
  Lines       52056    52321     +265     
==========================================
+ Hits        47225    47557     +332     
+ Misses       4831     4764      -67

Impacted Files	Coverage Δ
src/cross_module_fn.c	`66.84% <0.00%> (-0.72%)`	⬇️
tsl/src/init.c	`96.00% <ø> (ø)`
src/planner/planner.c	`95.82% <90.90%> (-0.09%)`	⬇️
tsl/src/fdw/data_node_scan_plan.c	`98.04% <97.95%> (-0.06%)`	⬇️
tsl/src/fdw/fdw.c	`94.32% <100.00%> (+0.12%)`	⬆️
tsl/src/fdw/relinfo.c	`97.51% <100.00%> (+1.63%)`	⬆️
tsl/src/fdw/shippable.c	`95.65% <100.00%> (-2.08%)`	⬇️
src/bgw/scheduler.c	`84.39% <0.00%> (-4.10%)`	⬇️
src/loader/bgw_launcher.c	`89.51% <0.00%> (-2.55%)`	⬇️
... and 9 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

tsl/src/fdw/data_node_scan_plan.c

erimatnor · 2023-01-31T13:53:15Z

tsl/src/fdw/data_node_scan_plan.c

+	 * This code does not work for joins with lateral references, since those
+	 * must have parameterized paths, which we don't generate yet.
+	 */
+	if (!bms_is_empty(joinrel->lateral_relids))


Can we add a test case with join lateral?

tsl/src/fdw/data_node_scan_plan.c

erimatnor · 2023-01-31T13:56:01Z

tsl/src/fdw/data_node_scan_plan.c

+	DataNodeScanPath *scanpath = palloc0(sizeof(DataNodeScanPath));
+
+	if (rel->lateral_relids && !bms_is_subset(rel->lateral_relids, required_outer))
+		required_outer = bms_union(required_outer, rel->lateral_relids);


Add test case?

erimatnor · 2023-01-31T13:56:15Z

tsl/src/fdw/data_node_scan_plan.c

+	 * revisit this.
+	 */
+	if (!bms_is_empty(required_outer) || !bms_is_empty(rel->lateral_relids))
+		elog(ERROR, "parameterized foreign joins are not supported yet");


Add test case?

These parameters are replaced before the data_node_scan_plan is generated in our implementation; this check is from PG upstream. However, I added a test case for a prepared statement to test that the join pushdown also works in this case.

We have a similar check also for regular scans in place. I wanted to check if we were covering this line in the existing tests. But unfortunately, codecov currently has an outage at the moment and I can't access the reports.

@erimatnor Codecov works now and I checked the coverage of the closely related line in the existing code. This line in the existing data_node_scan_path_create function is also one of these lines that are copied from PG upstream and cannot directly be tested in our implementation. So, it is hard to create a test case for the new/similar line.

https://app.codecov.io/gh/timescale/timescaledb/commit/0562c6d89aa757e7aa7f3acfaea3f3d386fe9f6c/blob/tsl/src/fdw/data_node_scan_plan.c#L1635

tsl/src/fdw/data_node_scan_plan.c

akuzm · 2023-02-13T12:56:17Z

tsl/src/fdw/data_node_scan_plan.c

+#endif
+	join_partition->reltarget->exprs =
+		castNode(List,
+				 adjust_appendrel_attrs(root, (Node *) joinrel->reltarget->exprs, 1, &appinfo));


Do we have to do this? The data node joinrel and the unpartitioned joinrel have the same relid.

Yes, this is needed. The join is performed partition-wise. Each of the partitions belongs to one data node and we are adjusting the expressions here using the appinfo of the data node.

Let's call it "data-node-wise" or something, because "partition" is ambiguous between chunks and data nodes. So which kind of adjustment exactly do we do? I see that adjust_apprendrel_attrs can change varno or convert row type. For data node joinrels, the varno and rowtype are the same, because we just copy them from the base joinrel. Does this function do anything else?

The function is renamed as suggested.

With adjust_apprendrel_attrs, the relid in the expressions is translated from the hypertable relid to the relid of the data node that is responsible for this partition. Otherwise, the deparser could not pushdown these expressions properly.

With adjust_apprendrel_attrs, the relid in the expressions is translated from the hypertable relid to the relid of the data node that is responsible for this partition.

Yes, but aren't they exactly equal? As set here: https://github.com/timescale/timescaledb/pull/5212/files#diff-47f57773f9558fb5ef0345e680eb19c0d1c9378c1701011b7a930a96e8a0813cR1135

This is relid in the sense of varno and RelOptInfo, not the oid from RTE.

Yes, these values are equal. However, in this function, we have to adjust the expressions for the join partition and make sure that the expressions (they are generated for the unpartitioned join) belong to this partition. We do something similar in adjust_data_node_rel_attrs for the DataNodes.

OK, I still don't understand what exactly it adjusts, given that the varno and row type are exactly the same, but I'll have to trust you on this :)

Sorry for the imprecise answer. The varno is adjusted at this point

For example, here you see the exprs before and after the adjustment. The varno of the expressions is translated from the input table position to the proper position of this specific DataNode entry in the simple_rel_array (the data node is at position 8 in this example). This is needed for the deparser to generate the SQL for the partition properly.

Original List

( {VAR :varno 1 :varattno 2 :vartype 23 :vartypmod -1 :varcollid 0 :varlevelsup 0 :varnosyn 1 :varattnosyn 2 :location -1 } [...] )

Adjusted List

( {VAR :varno 8 :varattno 2 :vartype 23 :vartypmod -1 :varcollid 0 :varlevelsup 0 :varnosyn 8 :varattnosyn 2 :location -1 } [...] )

tsl/src/fdw/data_node_scan_plan.c

akuzm · 2023-02-13T13:04:13Z

tsl/src/fdw/data_node_scan_plan.c

+	fpinfo =
+		fdw_relinfo_create(root, joinrel, InvalidOid, InvalidOid, TS_FDW_RELINFO_UNINITIALIZED);
+	Assert(fpinfo->type == TS_FDW_RELINFO_UNINITIALIZED);


What type is it going to have if we succesfully push down the join? I think "uninitialized" might be confusing here, maybe makes sense to initialize it with normal type but set pushdown_safe = false. Maybe even without going through fdw_relinfo_create, that function is very big and confusing.

The PostgreSQL logic is to add a dummy value to joinrel->fpinfo to indicate that we have already processed this joinrel (see this and this).

I introduced the TS_FDW_RELINFO_JOIN type to distinguish this fpinfo type from an actual TS_FDW_RELINFO_UNINITIALIZED fpinfo.

tsl/src/fdw/data_node_scan_plan.c

akuzm

Thanks for all the fixes, I think it's almost ideal now :)

erimatnor

Approving, although I have some inline comments.

erimatnor · 2023-02-22T11:21:18Z

src/cross_module_fn.c

@@ -555,6 +555,7 @@ TSDLLEXPORT CrossModuleFunctions ts_cm_functions_default = {
 	.hypertable_distributed_set_replication_factor = error_no_default_fn_pg_community,
 	.update_compressed_chunk_relstats = update_compressed_chunk_relstats_default,
 	.health_check = error_no_default_fn_pg_community,
+	.mn_get_foreign_join_paths = NULL,


Following the pattern here, you might want to add a dummy function instead (I guess one that does nothing by default). Then you can avoid a NULL check when using the function.

@erimatnor Good point. I introduced a dummy function.

erimatnor · 2023-02-22T11:25:48Z

tsl/src/fdw/data_node_scan_plan.c

+			break;
+
+		case JOIN_RIGHT:
+#if PG14_GE


Can we make dead code clear, by wrapping it in #if ENABLE_DEAD_CODE or marking it with pg_unreachable(), or similar so that the code is there but you can avoid having code coverage complain and it is obvious to the reader that the code isn't executed.

tsl/src/fdw/data_node_scan_plan.c

jnidzwetzki · 2023-02-23T10:41:39Z

@erimatnor I like the idea with the #ifdef ENABLE_DEAD_CODE statements. I added them to the larger blocks of currently unused code.

This patch adds the functionality that is needed to perform distributed, parallel joins on reference tables on access nodes. This code allows the pushdown of a join if: * (1) The setting "ts_guc_enable_per_data_node_queries" is enabled * (2) The outer relation is a distributed hypertable * (3) The inner relation is marked as a reference table * (4) The join is a left join or an inner join

@kovetskiy

This release includes these noteworthy features: * compressed hypertable enhancements: * UPDATE/DELETE support * ON CONFLICT DO UPDATE * Join support for hierarchical Continougs Aggregates * performance improvements **Features** * timescale#5212 Allow pushdown of reference table joins * timescale#5221 Improve Realtime Continuous Aggregate performance * timescale#5252 Improve unique constraint support on compressed hypertables * timescale#5339 Support UPDATE/DELETE on compressed hypertables * timescale#5344 Enable JOINS for Hierarchical Continuous Aggregates * timescale#5361 Add parallel support for partialize_agg() * timescale#5417 Refactor and optimize distributed COPY * timescale#5454 Add support for ON CONFLICT DO UPDATE for compressed hypertables * timescale#5547 Skip Ordered Append when only 1 child node is present * timescale#5510 Propagate vacuum/analyze to compressed chunks * timescale#5584 Reduce decompression during constraint checking * timescale#5530 Optimize compressed chunk resorting **Bugfixes** * timescale#5396 Fix SEGMENTBY columns predicates to be pushed down * timescale#5427 Handle user-defined FDW options properly * timescale#5442 Decompression may have lost DEFAULT values * timescale#5459 Fix issue creating dimensional constraints * timescale#5570 Improve interpolate error message on datatype mismatch * timescale#5573 Fix unique constraint on compressed tables * timescale#5615 Add permission checks to run_job() * timescale#5614 Enable run_job() for telemetry job * timescale#5578 Fix on-insert decompression after schema changes * timescale#5613 Quote username identifier appropriately * timescale#5525 Fix tablespace for compressed hypertable and corresponding toast * timescale#5642 Fix ALTER TABLE SET with normal tables * timescale#5666 Reduce memory usage for distributed analyze * timescale#5668 Fix subtransaction resource owner **Thanks** * @kovetskiy and @DZDomi for reporting peformance regression in Realtime Continuous Aggregates * @ollz272 for reporting an issue with interpolate error messages

@kovetskiy

This release contains new features and bug fixes since the 2.10.3 release. We deem it moderate priority for upgrading. This release includes these noteworthy features: * Support for DML operations on compressed chunks: * UPDATE/DELETE support * Support for unique constraints on compressed chunks * Support for `ON CONFLICT DO UPDATE` * Support for `ON CONFLICT DO NOTHING` * Join support for hierarchical Continuous Aggregates **Features** * timescale#5212 Allow pushdown of reference table joins * timescale#5221 Improve Realtime Continuous Aggregate performance * timescale#5252 Improve unique constraint support on compressed hypertables * timescale#5339 Support UPDATE/DELETE on compressed hypertables * timescale#5344 Enable JOINS for Hierarchical Continuous Aggregates * timescale#5361 Add parallel support for partialize_agg() * timescale#5417 Refactor and optimize distributed COPY * timescale#5454 Add support for ON CONFLICT DO UPDATE for compressed hypertables * timescale#5547 Skip Ordered Append when only 1 child node is present * timescale#5510 Propagate vacuum/analyze to compressed chunks * timescale#5584 Reduce decompression during constraint checking * timescale#5530 Optimize compressed chunk resorting * timescale#5639 Support sending telemetry event reports **Bugfixes** * timescale#5396 Fix SEGMENTBY columns predicates to be pushed down * timescale#5427 Handle user-defined FDW options properly * timescale#5442 Decompression may have lost DEFAULT values * timescale#5459 Fix issue creating dimensional constraints * timescale#5570 Improve interpolate error message on datatype mismatch * timescale#5573 Fix unique constraint on compressed tables * timescale#5615 Add permission checks to run_job() * timescale#5614 Enable run_job() for telemetry job * timescale#5578 Fix on-insert decompression after schema changes * timescale#5613 Quote username identifier appropriately * timescale#5525 Fix tablespace for compressed hypertable and corresponding toast * timescale#5642 Fix ALTER TABLE SET with normal tables * timescale#5666 Reduce memory usage for distributed analyze * timescale#5668 Fix subtransaction resource owner **Thanks** * @kovetskiy and @DZDomi for reporting peformance regression in Realtime Continuous Aggregates * @ollz272 for reporting an issue with interpolate error messages

@kovetskiy

This release contains new features and bug fixes since the 2.10.3 release. We deem it moderate priority for upgrading. This release includes these noteworthy features: * Support for DML operations on compressed chunks: * UPDATE/DELETE support * Support for unique constraints on compressed chunks * Support for `ON CONFLICT DO UPDATE` * Support for `ON CONFLICT DO NOTHING` * Join support for hierarchical Continuous Aggregates **Features** * timescale#5212 Allow pushdown of reference table joins * timescale#5221 Improve Realtime Continuous Aggregate performance * timescale#5252 Improve unique constraint support on compressed hypertables * timescale#5339 Support UPDATE/DELETE on compressed hypertables * timescale#5344 Enable JOINS for Hierarchical Continuous Aggregates * timescale#5361 Add parallel support for partialize_agg() * timescale#5417 Refactor and optimize distributed COPY * timescale#5454 Add support for ON CONFLICT DO UPDATE for compressed hypertables * timescale#5547 Skip Ordered Append when only 1 child node is present * timescale#5510 Propagate vacuum/analyze to compressed chunks * timescale#5584 Reduce decompression during constraint checking * timescale#5530 Optimize compressed chunk resorting * timescale#5639 Support sending telemetry event reports **Bugfixes** * timescale#5396 Fix SEGMENTBY columns predicates to be pushed down * timescale#5427 Handle user-defined FDW options properly * timescale#5442 Decompression may have lost DEFAULT values * timescale#5459 Fix issue creating dimensional constraints * timescale#5570 Improve interpolate error message on datatype mismatch * timescale#5573 Fix unique constraint on compressed tables * timescale#5615 Add permission checks to run_job() * timescale#5614 Enable run_job() for telemetry job * timescale#5578 Fix on-insert decompression after schema changes * timescale#5613 Quote username identifier appropriately * timescale#5525 Fix tablespace for compressed hypertable and corresponding toast * timescale#5642 Fix ALTER TABLE SET with normal tables * timescale#5666 Reduce memory usage for distributed analyze * timescale#5668 Fix subtransaction resource owner **Thanks** * @kovetskiy and @DZDomi for reporting peformance regression in Realtime Continuous Aggregates * @ollz272 for reporting an issue with interpolate error messages

@kovetskiy

This release contains new features and bug fixes since the 2.10.3 release. We deem it moderate priority for upgrading. This release includes these noteworthy features: * Support for DML operations on compressed chunks: * UPDATE/DELETE support * Support for unique constraints on compressed chunks * Support for `ON CONFLICT DO UPDATE` * Support for `ON CONFLICT DO NOTHING` * Join support for hierarchical Continuous Aggregates **Features** * #5212 Allow pushdown of reference table joins * #5221 Improve Realtime Continuous Aggregate performance * #5252 Improve unique constraint support on compressed hypertables * #5339 Support UPDATE/DELETE on compressed hypertables * #5344 Enable JOINS for Hierarchical Continuous Aggregates * #5361 Add parallel support for partialize_agg() * #5417 Refactor and optimize distributed COPY * #5454 Add support for ON CONFLICT DO UPDATE for compressed hypertables * #5547 Skip Ordered Append when only 1 child node is present * #5510 Propagate vacuum/analyze to compressed chunks * #5584 Reduce decompression during constraint checking * #5530 Optimize compressed chunk resorting * #5639 Support sending telemetry event reports **Bugfixes** * #5396 Fix SEGMENTBY columns predicates to be pushed down * #5427 Handle user-defined FDW options properly * #5442 Decompression may have lost DEFAULT values * #5459 Fix issue creating dimensional constraints * #5570 Improve interpolate error message on datatype mismatch * #5573 Fix unique constraint on compressed tables * #5615 Add permission checks to run_job() * #5614 Enable run_job() for telemetry job * #5578 Fix on-insert decompression after schema changes * #5613 Quote username identifier appropriately * #5525 Fix tablespace for compressed hypertable and corresponding toast * #5642 Fix ALTER TABLE SET with normal tables * #5666 Reduce memory usage for distributed analyze * #5668 Fix subtransaction resource owner **Thanks** * @kovetskiy and @DZDomi for reporting peformance regression in Realtime Continuous Aggregates * @ollz272 for reporting an issue with interpolate error messages

@kovetskiy

This release contains new features and bug fixes since the 2.10.3 release. We deem it moderate priority for upgrading. This release includes these noteworthy features: * Support for DML operations on compressed chunks: * UPDATE/DELETE support * Support for unique constraints on compressed chunks * Support for `ON CONFLICT DO UPDATE` * Support for `ON CONFLICT DO NOTHING` * Join support for hierarchical Continuous Aggregates **Features** * timescale#5212 Allow pushdown of reference table joins * timescale#5221 Improve Realtime Continuous Aggregate performance * timescale#5252 Improve unique constraint support on compressed hypertables * timescale#5339 Support UPDATE/DELETE on compressed hypertables * timescale#5344 Enable JOINS for Hierarchical Continuous Aggregates * timescale#5361 Add parallel support for partialize_agg() * timescale#5417 Refactor and optimize distributed COPY * timescale#5454 Add support for ON CONFLICT DO UPDATE for compressed hypertables * timescale#5547 Skip Ordered Append when only 1 child node is present * timescale#5510 Propagate vacuum/analyze to compressed chunks * timescale#5584 Reduce decompression during constraint checking * timescale#5530 Optimize compressed chunk resorting * timescale#5639 Support sending telemetry event reports **Bugfixes** * timescale#5396 Fix SEGMENTBY columns predicates to be pushed down * timescale#5427 Handle user-defined FDW options properly * timescale#5442 Decompression may have lost DEFAULT values * timescale#5459 Fix issue creating dimensional constraints * timescale#5570 Improve interpolate error message on datatype mismatch * timescale#5573 Fix unique constraint on compressed tables * timescale#5615 Add permission checks to run_job() * timescale#5614 Enable run_job() for telemetry job * timescale#5578 Fix on-insert decompression after schema changes * timescale#5613 Quote username identifier appropriately * timescale#5525 Fix tablespace for compressed hypertable and corresponding toast * timescale#5642 Fix ALTER TABLE SET with normal tables * timescale#5666 Reduce memory usage for distributed analyze * timescale#5668 Fix subtransaction resource owner **Thanks** * @kovetskiy and @DZDomi for reporting peformance regression in Realtime Continuous Aggregates * @ollz272 for reporting an issue with interpolate error messages

@kovetskiy

This release contains new features and bug fixes since the 2.10.3 release. We deem it moderate priority for upgrading. This release includes these noteworthy features: * Support for DML operations on compressed chunks: * UPDATE/DELETE support * Support for unique constraints on compressed chunks * Support for `ON CONFLICT DO UPDATE` * Support for `ON CONFLICT DO NOTHING` * Join support for hierarchical Continuous Aggregates **Features** * timescale#5212 Allow pushdown of reference table joins * timescale#5221 Improve Realtime Continuous Aggregate performance * timescale#5252 Improve unique constraint support on compressed hypertables * timescale#5339 Support UPDATE/DELETE on compressed hypertables * timescale#5344 Enable JOINS for Hierarchical Continuous Aggregates * timescale#5361 Add parallel support for partialize_agg() * timescale#5417 Refactor and optimize distributed COPY * timescale#5454 Add support for ON CONFLICT DO UPDATE for compressed hypertables * timescale#5547 Skip Ordered Append when only 1 child node is present * timescale#5510 Propagate vacuum/analyze to compressed chunks * timescale#5584 Reduce decompression during constraint checking * timescale#5530 Optimize compressed chunk resorting * timescale#5639 Support sending telemetry event reports **Bugfixes** * timescale#5396 Fix SEGMENTBY columns predicates to be pushed down * timescale#5427 Handle user-defined FDW options properly * timescale#5442 Decompression may have lost DEFAULT values * timescale#5459 Fix issue creating dimensional constraints * timescale#5570 Improve interpolate error message on datatype mismatch * timescale#5573 Fix unique constraint on compressed tables * timescale#5615 Add permission checks to run_job() * timescale#5614 Enable run_job() for telemetry job * timescale#5578 Fix on-insert decompression after schema changes * timescale#5613 Quote username identifier appropriately * timescale#5525 Fix tablespace for compressed hypertable and corresponding toast * timescale#5642 Fix ALTER TABLE SET with normal tables * timescale#5666 Reduce memory usage for distributed analyze * timescale#5668 Fix subtransaction resource owner **Thanks** * @kovetskiy and @DZDomi for reporting peformance regression in Realtime Continuous Aggregates * @ollz272 for reporting an issue with interpolate error messages

github-actions bot assigned jnidzwetzki Jan 24, 2023

jnidzwetzki force-pushed the distributed_join_dict_squashed branch from 0484057 to 4973f89 Compare January 24, 2023 09:09

jnidzwetzki force-pushed the distributed_join_dict_squashed branch 7 times, most recently from a437f70 to 07098d1 Compare January 24, 2023 15:31

jnidzwetzki added the multinode label Jan 25, 2023

jnidzwetzki force-pushed the distributed_join_dict_squashed branch 3 times, most recently from fea9905 to 4a68eb6 Compare January 27, 2023 13:32

jnidzwetzki requested review from erimatnor and nikkhils January 27, 2023 14:04

jnidzwetzki marked this pull request as ready for review January 27, 2023 14:04

erimatnor reviewed Jan 31, 2023

View reviewed changes

jnidzwetzki force-pushed the distributed_join_dict_squashed branch 12 times, most recently from e5c16e0 to 0562c6d Compare February 3, 2023 16:11

akuzm reviewed Feb 13, 2023

View reviewed changes

tsl/src/fdw/data_node_scan_plan.c Outdated Show resolved Hide resolved

akuzm reviewed Feb 13, 2023

View reviewed changes

tsl/src/fdw/data_node_scan_plan.c Outdated Show resolved Hide resolved

akuzm reviewed Feb 13, 2023

View reviewed changes

tsl/src/fdw/data_node_scan_plan.c Outdated Show resolved Hide resolved

jnidzwetzki force-pushed the distributed_join_dict_squashed branch 5 times, most recently from 60ec326 to d34c8a5 Compare February 15, 2023 12:24

akuzm approved these changes Feb 15, 2023

View reviewed changes

jnidzwetzki force-pushed the distributed_join_dict_squashed branch from d34c8a5 to 6471243 Compare February 15, 2023 13:15

erimatnor approved these changes Feb 22, 2023

View reviewed changes

jnidzwetzki force-pushed the distributed_join_dict_squashed branch 4 times, most recently from 5975570 to 2a4f0ec Compare February 23, 2023 10:33

jnidzwetzki force-pushed the distributed_join_dict_squashed branch from 2a4f0ec to a8661a5 Compare February 23, 2023 12:09

jnidzwetzki force-pushed the distributed_join_dict_squashed branch from a8661a5 to 788d671 Compare February 23, 2023 12:58

jnidzwetzki merged commit e0be9ea into timescale:main Feb 23, 2023

kgyrtkirk mentioned this pull request May 17, 2023

Release 2.11.0 #5695

Merged

kgyrtkirk mentioned this pull request May 19, 2023

Release 2.11.0 - fix date #5702

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Allow pushdown of reference table joins #5212

Allow pushdown of reference table joins #5212

jnidzwetzki commented Jan 24, 2023

codecov bot commented Jan 24, 2023 •

edited

erimatnor Jan 31, 2023

erimatnor Jan 31, 2023

erimatnor Jan 31, 2023

jnidzwetzki Feb 3, 2023 •

edited

jnidzwetzki Feb 7, 2023

akuzm Feb 13, 2023

jnidzwetzki Feb 14, 2023

akuzm Feb 14, 2023

jnidzwetzki Feb 14, 2023

akuzm Feb 14, 2023

jnidzwetzki Feb 15, 2023

akuzm Feb 15, 2023

jnidzwetzki Feb 15, 2023 •

edited

akuzm Feb 13, 2023

jnidzwetzki Feb 14, 2023

akuzm left a comment

erimatnor left a comment

erimatnor Feb 22, 2023

jnidzwetzki Feb 23, 2023

erimatnor Feb 22, 2023

jnidzwetzki commented Feb 23, 2023

Allow pushdown of reference table joins #5212

Allow pushdown of reference table joins #5212

Conversation

jnidzwetzki commented Jan 24, 2023

codecov bot commented Jan 24, 2023 • edited

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jnidzwetzki Feb 3, 2023 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jnidzwetzki Feb 15, 2023 • edited

Choose a reason for hiding this comment

Original List

Adjusted List

Choose a reason for hiding this comment

Choose a reason for hiding this comment

akuzm left a comment

Choose a reason for hiding this comment

erimatnor left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jnidzwetzki commented Feb 23, 2023

codecov bot commented Jan 24, 2023 •

edited

jnidzwetzki Feb 3, 2023 •

edited

jnidzwetzki Feb 15, 2023 •

edited