Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run dist_move_chunk as a solo test in PG15 #5248

Merged

Conversation

lkshminarayanan
Copy link
Contributor

@lkshminarayanan lkshminarayanan commented Jan 30, 2023

When run in a parallel group, the dist_move_chunk test can get into a deadlock with another test running a 'DROP DATABASE' command. So, mark it as a solo test to disallow it from running in a parallel group.

Closes #4972

Disable-check: force-changelog-changed

@codecov
Copy link

codecov bot commented Jan 30, 2023

Codecov Report

Merging #5248 (3892744) into main (03b740c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #5248   +/-   ##
=======================================
  Coverage   89.01%   89.01%           
=======================================
  Files         225      225           
  Lines       51807    51807           
=======================================
  Hits        46117    46117           
  Misses       5690     5690           
Impacted Files Coverage Δ
src/loader/bgw_launcher.c 89.51% <0.00%> (-2.55%) ⬇️
src/loader/bgw_message_queue.c 86.36% <0.00%> (-2.28%) ⬇️
src/bgw/job.c 93.40% <0.00%> (+0.16%) ⬆️
tsl/src/reorder.c 86.09% <0.00%> (+0.22%) ⬆️
src/bgw/job_stat.c 92.18% <0.00%> (+0.31%) ⬆️
src/bgw/scheduler.c 86.18% <0.00%> (+2.55%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03b740c...3892744. Read the comment docs.

@lkshminarayanan lkshminarayanan marked this pull request as ready for review January 31, 2023 07:07
@github-actions
Copy link

@svenklemm, @sb230132: please review this pull request.

Powered by pull-review

When run in a parallel group, the dist_move_chunk test can get into a
deadlock with another test running a 'DROP DATABASE' command. So, mark
it as a solo test to disallow it from running in a parallel group.

Closes timescale#4972
Copy link
Contributor

@jnidzwetzki jnidzwetzki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@lkshminarayanan lkshminarayanan merged commit 1a3e7ad into timescale:main Jan 31, 2023
@lkshminarayanan lkshminarayanan deleted the pg15-dist-move-chunk branch January 31, 2023 08:56
@akuzm akuzm added the auto-backport-not-done Automated backport of this PR has failed non-retriably (e.g. conflicts) label Jan 31, 2023
@timescale-automation
Copy link

Automated backport to 2.9.x not done: cherry-pick failed.

Job log

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport-not-done Automated backport of this PR has failed non-retriably (e.g. conflicts)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test dist_move_chunk hangs in PG15
6 participants