Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly format license error hint #5527

Merged
merged 1 commit into from Apr 10, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/cross_module_fn.c
Expand Up @@ -167,7 +167,7 @@ error_no_default_fn_community(void)
errmsg("functionality not supported under the current \"%s\" license. Learn more at "
"https://timescale.com/.",
ts_guc_license),
errhint("To get access to all features, and the best time-series experience try out "
errhint("To access all features and the best time-series experience, try out "
"Timescale Cloud.")));
}

Expand Down
4 changes: 2 additions & 2 deletions src/nodes/chunk_dispatch/chunk_dispatch.c
Expand Up @@ -160,8 +160,8 @@ ts_chunk_dispatch_get_chunk_insert_state(ChunkDispatch *dispatch, Point *point,
errmsg("functionality not supported under the current \"%s\" license. "
"Learn more at https://timescale.com/.",
ts_guc_license),
errhint("To get access to all features, and the best time-series "
"experience try out Timescale Cloud")));
errhint("To access all features and the best time-series "
"experience, try out Timescale Cloud")));
}

MemoryContextSwitchTo(old_context);
Expand Down
4 changes: 2 additions & 2 deletions test/expected/license.out
Expand Up @@ -54,7 +54,7 @@ SELECT create_hypertable('metrics', 'time');

ALTER TABLE metrics SET (timescaledb.compress);
ERROR: functionality not supported under the current "apache" license. Learn more at https://timescale.com/.
HINT: To get access to all features, and the best time-series experience try out Timescale Cloud.
HINT: To access all features and the best time-series experience, try out Timescale Cloud.
INSERT INTO metrics
VALUES ('2022-01-01 00:00:00', 1), ('2022-01-01 01:00:00', 2), ('2022-01-01 02:00:00', 3);
CREATE MATERIALIZED VIEW metrics_hourly
Expand All @@ -67,7 +67,7 @@ FROM metrics
GROUP BY bucket
WITH NO DATA;
ERROR: functionality not supported under the current "apache" license. Learn more at https://timescale.com/.
HINT: To get access to all features, and the best time-series experience try out Timescale Cloud.
HINT: To access all features and the best time-series experience, try out Timescale Cloud.
CREATE MATERIALIZED VIEW metrics_hourly
AS
SELECT time_bucket(INTERVAL '1 hour', time) AS bucket,
Expand Down