Properly format license error hint #5527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lkshminarayanan, @nikkhils: please review this pull request.
|
svenklemm
approved these changes
Apr 6, 2023
konskov
force-pushed
the
format_errmsg_community
branch
2 times, most recently
from
ae4b902
to
246b7cb
Compare
Codecov Report
@@ Coverage Diff @@
## main #5527 +/- ##
==========================================
- Coverage 90.45% 90.43% -0.03%
==========================================
Files 229 229
Lines 53854 53849 -5
==========================================
- Hits 48714 48698 -16
- Misses 5140 5151 +11
... and 5 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
konskov
force-pushed
the
format_errmsg_community
branch
from
246b7cb
to
bb2b4a0
Compare
RafiaSabih
approved these changes
Apr 6, 2023
Commit 57fde38 changed the messaging but did not format the error hint correctly. This patch fixes the error hint. Fixes timescale#5490
konskov
force-pushed
the
format_errmsg_community
branch
from
bb2b4a0
to
f4f0016
Compare
fabriziomello
approved these changes
Apr 6, 2023
mfreed
approved these changes
Apr 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 57fde38 changed the messaging but did not format the error hint correctly. This patch fixes the error hint.