Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compression settings informational view #6630

Merged
merged 1 commit into from Feb 13, 2024

Conversation

svenklemm
Copy link
Member

This patch adds 2 new views hypertable_compression_settings and chunk_compression_settings to query the per chunk compression settings.

Copy link

@akuzm, @mahipv: please review this pull request.

Powered by pull-review

@svenklemm svenklemm force-pushed the compression_settings_views branch 3 times, most recently from 89826aa to f9f9059 Compare February 10, 2024 12:31
@mkindahl mkindahl added compression docs-needed The issue or pull request requires documentation update labels Feb 12, 2024
@svenklemm svenklemm added this to the TimescaleDB 2.14.1 milestone Feb 12, 2024
LEFT JOIN _timescaledb_catalog.compression_settings s ON format('%I.%I',ht.schema_name,ht.table_name)::regclass = s.relid
LEFT JOIN LATERAL (
SELECT
array_to_string(array_agg(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
array_to_string(array_agg(
string_agg(

LEFT JOIN _timescaledb_catalog.compression_settings s ON format('%I.%I',ch2.schema_name,ch2.table_name)::regclass = s.relid
LEFT JOIN LATERAL (
SELECT
array_to_string(array_agg(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
array_to_string(array_agg(
string_agg(

sql/views.sql Outdated
LEFT JOIN _timescaledb_catalog.compression_settings s ON format('%I.%I',ht.schema_name,ht.table_name)::regclass = s.relid
LEFT JOIN LATERAL (
SELECT
array_to_string(array_agg(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
array_to_string(array_agg(
string_agg(

sql/views.sql Outdated
LEFT JOIN _timescaledb_catalog.compression_settings s ON format('%I.%I',ch2.schema_name,ch2.table_name)::regclass = s.relid
LEFT JOIN LATERAL (
SELECT
array_to_string(array_agg(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
array_to_string(array_agg(
string_agg(

Copy link
Contributor

@fabriziomello fabriziomello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Only thing is changing array_to_string(array_agg... to string_agg.

@svenklemm svenklemm force-pushed the compression_settings_views branch 2 times, most recently from 3699240 to b773bb6 Compare February 13, 2024 05:48
Copy link

codecov bot commented Feb 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (00f2f01) 80.00% compared to head (80cc1a6) 79.92%.
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6630      +/-   ##
==========================================
- Coverage   80.00%   79.92%   -0.08%     
==========================================
  Files         190      190              
  Lines       37217    37167      -50     
  Branches     9457     9436      -21     
==========================================
- Hits        29774    29706      -68     
- Misses       3030     3060      +30     
+ Partials     4413     4401      -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This patch adds 2 new views hypertable_compression_settings and
chunk_compression_settings to query the per chunk compression
settings.
@svenklemm svenklemm merged commit ea6d826 into timescale:main Feb 13, 2024
44 checks passed
@pallavisontakke pallavisontakke added bug force-auto-backport Automatically backport this PR or fix of this issue, even if it's not marked as "bug" labels Feb 14, 2024
@timescale-automation
Copy link

Automated backport to 2.14.x not done: cherry-pick failed.

Git status

HEAD detached at origin/2.14.x
You are currently cherry-picking commit ea6d826c1.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	new file:   .unreleased/pr_6630
	modified:   sql/updates/reverse-dev.sql
	modified:   sql/views.sql
	modified:   test/expected/pg_dump.out
	modified:   tsl/test/expected/compression_settings.out
	modified:   tsl/test/sql/compression_settings.sql

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   sql/updates/latest-dev.sql


Job log

@timescale-automation timescale-automation added the auto-backport-not-done Automated backport of this PR has failed non-retriably (e.g. conflicts) label Feb 14, 2024
svenklemm added a commit to svenklemm/timescaledb that referenced this pull request Feb 14, 2024
This release contains bug fixes since the 2.14.0 release.
We recommend that you upgrade at the next available opportunity.

**Features**
* timescale#6630 Add views for per chunk compression settings

**Bugfixes**
* timescale#6636 Fixes extension update of compressed hypertables with dropped columns
* timescale#6637 Reset sequence numbers on non-rollup compression
* timescale#6639 Disable default indexscan for compression
* timescale#6651 Fix DecompressChunk path generation with per chunk settings

**Thanks**
* @anajavi for reporting an issue with extension update of compressed hypertables
svenklemm added a commit that referenced this pull request Feb 14, 2024
This release contains bug fixes since the 2.14.0 release.
We recommend that you upgrade at the next available opportunity.

**Features**
* #6630 Add views for per chunk compression settings

**Bugfixes**
* #6636 Fixes extension update of compressed hypertables with dropped columns
* #6637 Reset sequence numbers on non-rollup compression
* #6639 Disable default indexscan for compression
* #6651 Fix DecompressChunk path generation with per chunk settings

**Thanks**
* @anajavi for reporting an issue with extension update of compressed hypertables
svenklemm added a commit that referenced this pull request Feb 14, 2024
This release contains bug fixes since the 2.14.0 release.
We recommend that you upgrade at the next available opportunity.

**Features**
* #6630 Add views for per chunk compression settings

**Bugfixes**
* #6636 Fixes extension update of compressed hypertables with dropped columns
* #6637 Reset sequence numbers on non-rollup compression
* #6639 Disable default indexscan for compression
* #6651 Fix DecompressChunk path generation with per chunk settings

**Thanks**
* @anajavi for reporting an issue with extension update of compressed hypertables
svenklemm added a commit that referenced this pull request Feb 14, 2024
This release contains bug fixes since the 2.14.0 release.
We recommend that you upgrade at the next available opportunity.

**Features**
* #6630 Add views for per chunk compression settings

**Bugfixes**
* #6636 Fixes extension update of compressed hypertables with dropped columns
* #6637 Reset sequence numbers on non-rollup compression
* #6639 Disable default indexscan for compression
* #6651 Fix DecompressChunk path generation with per chunk settings

**Thanks**
* @anajavi for reporting an issue with extension update of compressed hypertables
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport-not-done Automated backport of this PR has failed non-retriably (e.g. conflicts) backported-2.14.x bug compression docs-needed The issue or pull request requires documentation update force-auto-backport Automatically backport this PR or fix of this issue, even if it's not marked as "bug"
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants