Disable default indexscan for compression #6639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current code would always prefer indexscan over tuplesort while doing scans of the rows from the chunk that was being compressed. The thinking was that we'd avoid doing a sort via the indexscan. The theory looked good on paper, but from various cloud customer reports we have seen that the random access of the heap pages via the indexscan was typically more expensive than doing the tuplesort. So we disable the default indexscan till we get better usecases warranting enabling it again for all scenarios. Specific use cases can enable the timescaledb.enable_compression_indexscan manually if desired.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6639 +/- ##
==========================================
- Coverage 79.99% 79.99% -0.01%
==========================================
Files 190 190
Lines 37217 37171 -46
Branches 9457 9440 -17
==========================================
- Hits 29773 29736 -37
- Misses 3032 3036 +4
+ Partials 4412 4399 -13 ☔ View full report in Codecov by Sentry. |
svenklemm
approved these changes
Feb 12, 2024
cevian
approved these changes
Feb 12, 2024
fabriziomello
approved these changes
Feb 12, 2024
pallavisontakke
added
bug
force-auto-backport
svenklemm
added a commit
to svenklemm/timescaledb
that referenced
this pull request
Feb 14, 2024
This release contains bug fixes since the 2.14.0 release. We recommend that you upgrade at the next available opportunity. **Features** * timescale#6630 Add views for per chunk compression settings **Bugfixes** * timescale#6636 Fixes extension update of compressed hypertables with dropped columns * timescale#6637 Reset sequence numbers on non-rollup compression * timescale#6639 Disable default indexscan for compression * timescale#6651 Fix DecompressChunk path generation with per chunk settings **Thanks** * @anajavi for reporting an issue with extension update of compressed hypertables
svenklemm
added a commit
that referenced
this pull request
Feb 14, 2024
This release contains bug fixes since the 2.14.0 release. We recommend that you upgrade at the next available opportunity. **Features** * #6630 Add views for per chunk compression settings **Bugfixes** * #6636 Fixes extension update of compressed hypertables with dropped columns * #6637 Reset sequence numbers on non-rollup compression * #6639 Disable default indexscan for compression * #6651 Fix DecompressChunk path generation with per chunk settings **Thanks** * @anajavi for reporting an issue with extension update of compressed hypertables
svenklemm
added a commit
that referenced
this pull request
Feb 14, 2024
This release contains bug fixes since the 2.14.0 release. We recommend that you upgrade at the next available opportunity. **Features** * #6630 Add views for per chunk compression settings **Bugfixes** * #6636 Fixes extension update of compressed hypertables with dropped columns * #6637 Reset sequence numbers on non-rollup compression * #6639 Disable default indexscan for compression * #6651 Fix DecompressChunk path generation with per chunk settings **Thanks** * @anajavi for reporting an issue with extension update of compressed hypertables
svenklemm
added a commit
that referenced
this pull request
Feb 14, 2024
This release contains bug fixes since the 2.14.0 release. We recommend that you upgrade at the next available opportunity. **Features** * #6630 Add views for per chunk compression settings **Bugfixes** * #6636 Fixes extension update of compressed hypertables with dropped columns * #6637 Reset sequence numbers on non-rollup compression * #6639 Disable default indexscan for compression * #6651 Fix DecompressChunk path generation with per chunk settings **Thanks** * @anajavi for reporting an issue with extension update of compressed hypertables
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current code would always prefer indexscan over tuplesort while doing scans of the rows from the chunk that was being compressed. The thinking was that we'd avoid doing a sort via the indexscan. The theory looked good on paper, but from various cloud customer reports we have seen that the random access of the heap pages via the indexscan was typically more expensive than doing the tuplesort. So we disable the default indexscan till we get better usecases warranting enabling it again for all scenarios. Specific use cases can enable the timescaledb.enable_compression_indexscan manually if desired.
Disable-check: force-changelog-file