Use "unlikely" with Ensure #6648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since conditions used with `Ensure` are not expected to fire except in rare circumstances, we should always treat this as unlikely.
|
@jnidzwetzki, @svenklemm: please review this pull request.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6648 +/- ##
==========================================
+ Coverage 80.05% 80.09% +0.03%
==========================================
Files 190 190
Lines 37179 37133 -46
Branches 9450 9433 -17
==========================================
- Hits 29763 29740 -23
+ Misses 3001 2994 -7
+ Partials 4415 4399 -16 ☔ View full report in Codecov by Sentry. |
akuzm
approved these changes
Feb 13, 2024
jnidzwetzki
added a commit
to jnidzwetzki/timescaledb
that referenced
this pull request
Feb 21, 2024
PR timescale#6648 introduces a branch prediction in the Ensure macro. However, the checked condition needs to be negated to be unlikely. Therefore, the check predicts the branch likelihood wrongly. In other words, reporting an error in Ensure should be the unlikely case, and the condition should be fulfilled in most calls. This commit fixes the branch prediction.
jnidzwetzki
added a commit
to jnidzwetzki/timescaledb
that referenced
this pull request
Feb 21, 2024
PR timescale#6648 introduces a branch prediction in the Ensure macro. However, the checked condition needs to be negated to be unlikely. Therefore, the check predicts the branch likelihood wrongly. In other words, reporting an error in Ensure should be the unlikely case, and the condition should be fulfilled in most calls. This commit fixes the branch prediction.
jnidzwetzki
added a commit
that referenced
this pull request
Feb 22, 2024
PR #6648 introduces a branch prediction in the Ensure macro. However, the checked condition needs to be negated to be unlikely. Therefore, the check predicts the branch likelihood wrongly. In other words, reporting an error in Ensure should be the unlikely case, and the condition should be fulfilled in most calls. This commit fixes the branch prediction.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since conditions used with
Ensureare not expected to fire except in rare circumstances, we should always treat this as unlikely.Disable-check: force-changelog-file