Fix backport script when PR references an issue from another repo #6824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were always looking at the referenced issue number in the timescaledb repo, which is incorrect.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6824 +/- ##
==========================================
+ Coverage 80.06% 81.00% +0.93%
==========================================
Files 190 197 +7
Lines 37181 37029 -152
Branches 9450 9665 +215
==========================================
+ Hits 29770 29996 +226
- Misses 2997 3183 +186
+ Partials 4414 3850 -564 ☔ View full report in Codecov by Sentry. |
jnidzwetzki
reviewed
Apr 11, 2024
| } | ||
| nodes { | ||
| number, title, | ||
| labels (first: 30) { nodes { name } } |
There was a problem hiding this comment.
Could you document why the limitation of 30 was chosen?
There was a problem hiding this comment.
Just some arbitrary number, it is required here by GitHub. It should be not very big because it's counted towards the usage quota of the GraphQL API. I'll add a comment there.
jnidzwetzki
approved these changes
Apr 11, 2024
svenklemm
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were always looking at the referenced issue number in the timescaledb repo, which is incorrect.
Disable-check: force-changelog-file