Add VictoriaMetrics support #96

hagen1778 · 2019-10-04T06:37:14Z

This PR adds support for opensource timeseries database VictoriaMetrics.

VM supports InfluxDB ingestion protocol, so tsbs_load_victoriametrics is very similar to tsbs_load_influx.

VictoriaMetrics supports PromQL which has some limitations comparing to SQL. Because of this VictoriaMetrics query generator lacks for implementation of query types groupby-orderby-limit and lastpoint for devops use-case and all queries for iot use-case. But for other cases it still may be comparable with other databases.

We also believe this PR may help with adding of Prometheus to the list of supported databases.

* add VictoriaMetrics generator * add VictoriaMetrics loader * add VictoriaMetrics query generator * support multiple URLs for loading data into VM * fix loader workers support * add VictoriaMetrics query runner * fix query generator * use default HTTP client * mention VictoriaMetrics in README * add load script and extend documentation * address review comments

codecov-io · 2019-10-04T06:40:16Z

Codecov Report

Merging #96 into master will increase coverage by 0.17%.
The diff coverage is 74.11%.

@@            Coverage Diff             @@
##           master      #96      +/-   ##
==========================================
+ Coverage   69.55%   69.72%   +0.17%     
==========================================
  Files         104      110       +6     
  Lines        5810     5982     +172     
==========================================
+ Hits         4041     4171     +130     
- Misses       1690     1722      +32     
- Partials       79       89      +10

Impacted Files	Coverage Δ
internal/inputs/utils.go	`78.26% <ø> (ø)`	⬆️
cmd/tsbs_load_victoriametrics/creator.go	`0% <0%> (ø)`
internal/inputs/generator_data.go	`88.96% <100%> (+0.14%)`	⬆️
cmd/tsbs_load_victoriametrics/main.go	`29.03% <29.03%> (ø)`
internal/inputs/generator_queries.go	`72.45% <33.33%> (-0.72%)`	⬇️
cmd/tsbs_load_victoriametrics/processor.go	`73.91% <73.91%> (ø)`
cmd/tsbs_load_victoriametrics/scan.go	`75% <75%> (ø)`
...nerate_queries/databases/victoriametrics/common.go	`91.3% <91.3%> (ø)`
...nerate_queries/databases/victoriametrics/devops.go	`96.66% <96.66%> (ø)`
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c4f0c1...f3e0002. Read the comment docs.

RobAtticus · 2019-10-11T19:55:50Z

Hi, thanks for this, we'll put it on our radar to review!

tenmozes · 2019-10-18T16:03:00Z

@RobAtticus could you please take a look?

RobAtticus · 2019-10-18T17:31:01Z

I've been out at conferences, so I might be able to next week. @blagojts if you have some spare cycles, make take an initial pass?

syepes · 2019-10-29T15:46:11Z

+1

� Conflicts: � internal/inputs/utils.go

hagen1778 · 2019-11-09T22:42:09Z

Hi @RobAtticus! Any chance to get it reviewed?

tenmozes · 2019-12-05T11:41:33Z

Hi folks, any updates on this PR?

� Conflicts: � README.md � internal/inputs/generator_queries.go � internal/inputs/utils.go

hagen1778 · 2020-02-01T18:51:07Z

Hello! Any updates on this?

freeseacher · 2020-02-18T18:45:16Z

Hi! any news ?

toddlipcon · 2020-03-04T22:21:42Z

cmd/tsbs_generate_queries/databases/victoriametrics/devops.go

+// 		{__name__=~'cpu_.*', hostname=~"hostname1|hostname2...|hostnameN"}[12h]
+// 	)
+// ) by (hostname) > 90
+func (d *Devops) HighCPUForHosts(qq query.Query, nHosts int) {


This seems to be returning very different data than infuxdb -- the 12h grouping here isn't present in the equivalent influx or timescale query. Thus those systems return several hundred MB of JSON whereas Victoria is returning only two data points per host, making it way faster.

Thanks for noticing! I removed this case since it is unclear how to support it via MetricsQL/PromQL. The query model assumes step (grouping by time) to be always set. So to satisfy this case we need to pass log-interval flag value used for generating data which we don't know when generating queries. I hope other cases are consistent and comparable with other databases. Thank you again!

…atabase since it can't be supported via MetricsQL query language due to data model specifics

RobAtticus

First, let me apologize for the delay in reviewing this. I've been focused on a different effort at the company so this stuff unfortunately did not make it to the top of my queue, but I should have found someone to do it. Thanks for dealing with the other comments people had.

I just have a few minor suggestions, mostly around documentation.

RobAtticus · 2020-03-10T21:38:05Z

README.md


 ¹ Does not support the `groupby-orderby-limit` query
+² Does not support the `groupby-orderby-limit` and `lastpoint` queries


needs to include that it does not support high-cpu-1 and high-cpu-all

RobAtticus · 2020-03-10T21:41:15Z

cmd/tsbs_run_queries_victoriametrics/main.go

@@ -0,0 +1,127 @@
+// tsbs_run_queries_clickhouse speed tests ClickHouse using requests from stdin or file.


comment needs to be updated

RobAtticus · 2020-03-10T21:42:09Z

docs/victoriametrics.md

+types for `devops` use-case: 
+* `groupby-orderby-limit` - results are always ordered by time and can't be limited;
+* `lastpoint` - can't be queried if datapoint is older than 5 minutes; 
+* `high-cpu` - can't be queried without grouping by step.


high-cpu-1/high-cpu-all

…query types

…er package

hagen1778 · 2020-03-11T21:06:03Z

Thx for review @RobAtticus! Addressed the comments. Pls let me know if there is anything else I can do.

hagen1778 · 2020-04-11T20:05:07Z

@RobAtticus ping

AlekseyKanaev · 2020-05-07T12:44:36Z

Any updates on the PR?

RobAtticus · 2020-05-11T18:21:47Z

Merged! Thanks again for your patience

hagen1778 added 5 commits September 26, 2019 01:12

Merge branch 'master' of https://github.com/timescale/tsbs into master2

413ab98

update readme for victoriametrics

6c93cfa

add install commands to VM readme

5f241eb

mention that query generator for VM lacks iot use-case implementation

683bf91

hagen1778 added 4 commits October 5, 2019 10:32

add devops tests

e52933a

add generator test for VM

e499cea

move specific funcs into VM package

f346d23

add processor test for VM

6e03aac

Merge branch 'master' of https://github.com/timescale/tsbs into master2

46f535f

� Conflicts: � internal/inputs/utils.go

hagen1778 mentioned this pull request Nov 9, 2019

RFE: Run tsbs against Prometheus preferably deployed in a k8s cluster #66

Open

valyala mentioned this pull request Dec 23, 2019

Add VictoriaMetrics to the list of tested databases influxdata/influxdb-comparisons#155

Open

hagen1778 added 2 commits January 11, 2020 21:13

Merge branch 'master' of https://github.com/timescale/tsbs into master2

02d15d3

� Conflicts: � README.md � internal/inputs/generator_queries.go � internal/inputs/utils.go

mention VM in the table of supported cases

076d829

toddlipcon reviewed Mar 4, 2020

View reviewed changes

remove high-cpu use-case from queries generator for VictoriaMetrics d…

f3e0002

…atabase since it can't be supported via MetricsQL query language due to data model specifics

hagen1778 force-pushed the master2 branch from e187fd9 to f3e0002 Compare March 9, 2020 23:41

RobAtticus reviewed Mar 10, 2020

View reviewed changes

hagen1778 added 2 commits March 11, 2020 20:57

update comments and documentation according to changes for supported …

7fd2761

…query types

fix the copy&paste typo in description for VictoriaMetrics query runn…

cf7b85f

…er package

RobAtticus approved these changes May 11, 2020

View reviewed changes

RobAtticus merged commit 09e0e8a into timescale:master May 11, 2020

valyala deleted the master2 branch May 12, 2020 19:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add VictoriaMetrics support #96

Add VictoriaMetrics support #96

hagen1778 commented Oct 4, 2019

codecov-io commented Oct 4, 2019 •

edited

Loading

RobAtticus commented Oct 11, 2019

tenmozes commented Oct 18, 2019

RobAtticus commented Oct 18, 2019

syepes commented Oct 29, 2019

hagen1778 commented Nov 9, 2019

tenmozes commented Dec 5, 2019

hagen1778 commented Feb 1, 2020

freeseacher commented Feb 18, 2020

toddlipcon Mar 4, 2020

hagen1778 Mar 9, 2020

RobAtticus left a comment

RobAtticus Mar 10, 2020

RobAtticus Mar 10, 2020

RobAtticus Mar 10, 2020

hagen1778 commented Mar 11, 2020

hagen1778 commented Apr 11, 2020

AlekseyKanaev commented May 7, 2020

RobAtticus commented May 11, 2020


		¹ Does not support the `groupby-orderby-limit` query
		² Does not support the `groupby-orderby-limit` and `lastpoint` queries

		@@ -0,0 +1,127 @@
		// tsbs_run_queries_clickhouse speed tests ClickHouse using requests from stdin or file.

Add VictoriaMetrics support #96

Add VictoriaMetrics support #96

Conversation

hagen1778 commented Oct 4, 2019

codecov-io commented Oct 4, 2019 • edited Loading

Codecov Report

RobAtticus commented Oct 11, 2019

tenmozes commented Oct 18, 2019

RobAtticus commented Oct 18, 2019

syepes commented Oct 29, 2019

hagen1778 commented Nov 9, 2019

tenmozes commented Dec 5, 2019

hagen1778 commented Feb 1, 2020

freeseacher commented Feb 18, 2020

toddlipcon Mar 4, 2020

Choose a reason for hiding this comment

hagen1778 Mar 9, 2020

Choose a reason for hiding this comment

RobAtticus left a comment

Choose a reason for hiding this comment

RobAtticus Mar 10, 2020

Choose a reason for hiding this comment

RobAtticus Mar 10, 2020

Choose a reason for hiding this comment

RobAtticus Mar 10, 2020

Choose a reason for hiding this comment

hagen1778 commented Mar 11, 2020

hagen1778 commented Apr 11, 2020

AlekseyKanaev commented May 7, 2020

RobAtticus commented May 11, 2020

codecov-io commented Oct 4, 2019 •

edited

Loading