-
Notifications
You must be signed in to change notification settings - Fork 635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multilabel TSClassification Tutorial Notebook Example is Broken #847
Comments
@oguiza @williamsdoug But when I checked out v0.3.5 that bit of code ran without error! I will post back soon with any other diagnostic information that I discover. Thanks for creating this awesome package and example code. |
For the
Clearly something has changed and maybe its not shaping up the output properly? For the Multi-class
|
@oguiza
Could be a regression, I will try to study what the fixes were there until someone more qualified can take over ;) |
… shape auto configuration
@oguiza It would be awesome if the maintainers can help with implementing the fix. I have about exhausted my capabilities to really understand how the magic model auto-configuration system is supposed to work. Once a fix is decided upon and tested, I will happily close out the issue! |
Having the same issue! |
…re config clauses in build_ts_model, an assumption was made to put it in the list next to InceptionTime -> FIX for issue timeseriesAI#847
@oguiza @Munib5 Tracing what is going wrong is a bit maddening. The problem starts with the creation of the At this point the
When the learn = ts_learner(dls, InceptionTimePlus, metrics=accuracy_multi, verbose=True) it delegates to Still inside
here d=6. The model = arch(c_in, c_out, seq_len=seq_len, **arch_config, **kwargs).to(device=device) As indicated by this printout if you set
Subsequently when the shape == [6,6]
fd == 6 Later in that constructor (see code), this problematically shaped layer is appended to the model: else:
if seq_len == 1:
layers += [nn.AdaptiveAvgPool1d(1)]
if not flatten and fd == seq_len:
layers += [Transpose(1,2), nn.Linear(n_in, n_out)]
else:
layers += [Reshape(), nn.Linear(n_in * seq_len, n_out * fd)]
layers += [Reshape(*shape)] where the keys variables take on these values: n_in == 128
seq_len == 140
n_out == 6
fd == 6
shape == [6,6] That shows that there is potentially a conflict between the property Again, my limited understanding of the architecture of this library is providing a major impediment for finding a fix that will satisfy everyone :) Here's hoping that the maintainers will take over! |
@Munib5 learn = ts_learner(dls, InceptionTimePlus, metrics=accuracy_multi, verbose=True, d=1) where we force the |
When running notebook
![image](https://private-user-images.githubusercontent.com/1470227/273286778-e5507cf7-1457-4aeb-9d7b-530b89d3aabc.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjU2Nzk1NjksIm5iZiI6MTcyNTY3OTI2OSwicGF0aCI6Ii8xNDcwMjI3LzI3MzI4Njc3OC1lNTUwN2NmNy0xNDU3LTRhZWItOWQ3Yi01MzBiODlkM2FhYmMucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDkwNyUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA5MDdUMDMyMTA5WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9MDc2MWMzOWE2MDMwYWNjMWI0OTA1ODVmMzdmOTBhOTJjZTA0M2Q5ZWU2Zjc4Y2Q0ZmI3Mjk2MDFmZDRmNDM5MyZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.SFscMg84ZUlrQctL1FU-yYAaBKTOlyDwt19Az2JVxVQ)
01a_MultiClass_MultiLabel_TSClassification.ipynb
under the MultiLabel section, specifically this cell code, results in this error (cropped screen shot):Here is the full traceback:
I'm running this commit locally (currently head of main branch) and the output of
my_setup()
is:I would be happy to spend quite a bit more effort in figuring out the right way to do this example. Thanks!
The text was updated successfully, but these errors were encountered: