handling missing migrations with grace and truth

timgit · Mar 3, 2017 · bfa0bc4 · bfa0bc4
1 parent ef7c755
commit bfa0bc4
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 0 deletions.
diff --git a/src/db.js b/src/db.js
@@ -48,6 +48,11 @@ class Db {
     migrate(version, uninstall) {
         let migration = migrations.get(this.config.schema, version, uninstall);
 
+        if(!migration){
+            let errorMessage = `Migration to version ${version} failed because it could not be found.  Your database may have been upgraded by a newer version of pg-boss`;
+            return Promise.reject(new Error(errorMessage));
+        }
+
         return Promise.each(migration.commands, command => this.executeSql(command))
             .then(() => migration.version);
     }

diff --git a/test/migrationTest.js b/test/migrationTest.js
@@ -45,4 +45,14 @@ describe('migration', function() {
             });
     });
 
+    it('migrating to non-existent version fails gracefully', function(finished){
+
+        contractor.create()
+            .then(() => db.migrate('¯\_(ツ)_/¯'))
+            .catch(error => {
+                assert(error.message.indexOf('could not be found') > -1);
+                finished();
+            });
+    });
+
 });