Add TypeScript type definitions #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@druska, thanks for the PR. I've yet to use this in a Typescript project yet, but I can see how handy this would be. Did you hand-create this, or did you use a tool to auto-gen most of it? If I were to take over maintenance, I'd like to automate it as much as possible. That is, something I could use outside of a full-blown rewrite in TS. 😱 |
|
@timgit if the project is written in plain JavaScript, it's something you have to maintain yourself unfortunately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for the awesome queueing framework! I've added TypeScript type definitions. If you don't want to be responsible for maintaining this, we can add them to DefinitelyTyped instead. Integrated is preferable for TypeScript users.