Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate method-overwritten warnings #1

Open
timholy opened this issue Aug 5, 2018 · 2 comments
Open

Eliminate method-overwritten warnings #1

timholy opened this issue Aug 5, 2018 · 2 comments
Labels
help wanted Extra attention is needed

Comments

@timholy
Copy link
Owner

timholy commented Aug 5, 2018

@Keno, you might find this package somewhere between intriguing and annoying 😄. See the README for an overview.

I found the logic to handle transitions to be tricky, especially while searching history. In the end I gave up and just re-defined some methods in REPL/LineEdit.jl. In the longer term it would be good to fix that. A bigger question is whether a custom AbstractREPL is really the way to do this, or whether some new kind of AbstractPrompt would be more appropriate. There are a lot of methods specialized for Prompt, so in the interests of minimal duplication/disruption at this stage of Julia's release I went with the AbstractREPL approach so I could use Prompt's repl field to attach the required additional information.

@tpapp
Copy link

tpapp commented Apr 5, 2019

For a while I did not get warnings, but they are back again (startup after pkg> up):

Info: Generating builtins for this julia version...
WARNING: Method definition deactivate(REPL.LineEdit.TextInterface, REPL.LineEdit.ModeState, Any, REPL.Terminals.TextTerminal) in module LineEdit at /home/tamas/src/julia-git/usr/share/julia/stdlib/v1.2/REPL/src/LineEdit.jl:2204 overwritten in module HeaderREPLs at /home/tamas/.julia/packages/HeaderREPLs/xrHVE/src/HeaderREPLs.jl:396.
  ** incremental compilation may be fatally broken for this module **

WARNING: Method definition transition(Function, REPL.LineEdit.PrefixSearchState, Any) in module LineEdit at /home/tamas/src/julia-git/usr/share/julia/stdlib/v1.2/REPL/src/LineEdit.jl:1701 overwritten in module HeaderREPLs at /home/tamas/.julia/packages/HeaderREPLs/xrHVE/src/HeaderREPLs.jl:327.
  ** incremental compilation may be fatally broken for this module **

WARNING: Method definition activate(REPL.LineEdit.TextInterface, REPL.LineEdit.ModeState, Any, REPL.Terminals.TextTerminal) in module LineEdit at /home/tamas/src/julia-git/usr/share/julia/stdlib/v1.2/REPL/src/LineEdit.jl:2209 overwritten in module HeaderREPLs at /home/tamas/.julia/packages/HeaderREPLs/xrHVE/src/HeaderREPLs.jl:382.
  ** incremental compilation may be fatally broken for this module **

               _
   _       _ _(_)_     |  Documentation: https://docs.julialang.org
  (_)     | (_) (_)    |
   _ _   _| |_  __ _   |  Type "?" for help, "]?" for Pkg help.
  | | | | | | |/ _` |  |
  | | |_| | | | (_| |  |  Version 1.2.0-DEV.654 (2019-04-05)
 _/ |\__'_|_|_|\__'_|  |  Commit bef16eee72 (0 days old master)
|__/                   |

(v1) pkg> st --manifest Rebugger
    Status `~/.julia/environments/v1/Manifest.toml`
  [da1fd8a2] CodeTracking v0.5.5
  [54d51984] HeaderREPLs v0.3.0
  [aa1ae85d] JuliaInterpreter v0.4.1
  [ee283ea6] Rebugger v0.3.1
  [295af30f] Revise v2.0.6
  [b77e0a4c] InteractiveUtils 
  [44cfe95a] Pkg 
  [3fa0cd96] REPL 
  [8dfed614] Test 
  [cf7118a7] UUIDs 

julia> versioninfo()
Julia Version 1.2.0-DEV.654
Commit bef16eee72 (2019-04-05 02:32 UTC)
Platform Info:
  OS: Linux (x86_64-linux-gnu)
  CPU: Intel(R) Core(TM) i7-6560U CPU @ 2.20GHz
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-6.0.1 (ORCJIT, skylake)
Environment:
  JULIA_REVISE_INCLUDE = 1
  JULIA_CMDSTAN_HOME = /home/tamas/src/cmdstan-2.18.1/

@timholy timholy added the help wanted Extra attention is needed label Apr 5, 2019
@timholy
Copy link
Owner Author

timholy commented Apr 5, 2019

You'll always get them when you rebuild. They are just more threatening now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants