Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak anonrex #31

Merged
merged 1 commit into from
Nov 19, 2019
Merged

Tweak anonrex #31

merged 1 commit into from
Nov 19, 2019

Conversation

timholy
Copy link
Owner

@timholy timholy commented Nov 19, 2019

Should also get the tests passing on Travis

@yhls
Copy link

yhls commented Nov 19, 2019

Did we want to exclude anonymous functions of the form ##something#123?

@timholy
Copy link
Owner Author

timholy commented Nov 19, 2019

I'm torn. Generators like ##s27#8 are reproducible until the code changes, maybe it doesn't hurt to keep them?

@yhls
Copy link

yhls commented Nov 19, 2019

I think they're not reproducible across different versions of Julia, but I guess #30 makes them harmless.

@timholy
Copy link
Owner Author

timholy commented Nov 19, 2019

There will be a different precompile cache anyway for different versions.

I think I'll go with this and we can consider pruning more methods later.

@timholy timholy merged commit adef272 into master Nov 19, 2019
@timholy timholy deleted the teh/tests branch November 19, 2019 19:20
@timholy timholy mentioned this pull request Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants