check that functions in precompile lists are defined #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry I didn't notice this or forgot about it! I don't see anything objectionable here. Any reason not to merge for now? |
lkapelevich
changed the title
|
No problem! I don't have any more changes to make to the code. If you have suggestions for how to test this better, I'm happy to try them. |
Merged
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #29
This works for the example in the issue, but I'm not sure I have implemented it in the most effective way, or what the best way to test this is. If
func(https://github.com/timholy/SnoopCompile.jl/blob/master/src/SnoopCompile.jl#L194) looks like:(getfield(mod, Symbol("##...#.."))), we add a checkisdefined(mod, "##...#..").